Added "preconfiguredWafConfig" and "rateLimitOptions" support to region security policy rule

[matheusaleixo-cit]

Adds support for 'preconfiguredWafConfig' and 'rateLimitOptions' fields to 'google_compute_region_security_policy_rule'

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17442

Release Note Template for Downstream PRs (will be copied)

compute: Added 'preconfiguredWafConfig' field to 'google_compute_region_security_policy_rule' resource;

compute: Added 'rateLimitOptions' field to 'google_compute_region_security_policy_rule' resource;

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 284 insertions(+)) google-beta provider: Diff ( 4 files changed, 1795 insertions(+), 60 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 437 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_security_policy_rule (14 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_security_policy_rule" "primary" {
  rate_limit_options {
    enforce_on_key_configs {
      enforce_on_key_name = # value needed
      enforce_on_key_type = # value needed
    }
    enforce_on_key_name = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 908 Passed tests: 833 Skipped tests: 72 Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample|TestAccComputeRegionSecurityPolicyRule_withPreconfiguredWafConfig|TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionSecurityPolicyRule_withPreconfiguredWafConfig[Debug log] TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 280 insertions(+)) google-beta provider: Diff ( 4 files changed, 1787 insertions(+), 60 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 437 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_security_policy_rule (14 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_security_policy_rule" "primary" {
  rate_limit_options {
    enforce_on_key_configs {
      enforce_on_key_name = # value needed
      enforce_on_key_type = # value needed
    }
    enforce_on_key_name = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 908 Passed tests: 835 Skipped tests: 72 Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[trodge]

Test is failing with this error:

2024-04-29T22:35:38.076Z [ERROR] sdk.helper_resource: Unexpected error: test_working_directory=/tmp/plugintest3947767888
  error=
  | Error running pre-apply refresh: exit status 1
  | 
  | Error: Inconsistent dependency lock file
  | 
  | The following dependency selections recorded in the lock file are
  | inconsistent with the current configuration:
  |   - provider registry.terraform.io/hashicorp/google: required by this configuration but no version is selected
  | 
  | To make the initial dependency selections that will initialize the dependency
  | lock file, run:
  |   terraform init
   test_step_number=1 test_name=TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample test_terraform_path=/bin/terraform

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 284 insertions(+)) google-beta provider: Diff ( 4 files changed, 1795 insertions(+), 60 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 437 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_security_policy_rule (14 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_security_policy_rule" "primary" {
  rate_limit_options {
    enforce_on_key_configs {
      enforce_on_key_name = # value needed
      enforce_on_key_type = # value needed
    }
    enforce_on_key_name = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 908 Passed tests: 835 Skipped tests: 72 Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleWithPreconfiguredWafConfigExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 288 insertions(+)) google-beta provider: Diff ( 4 files changed, 2166 insertions(+), 60 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 437 insertions(+))

[modular-magician]

Tests analytics

Total tests: 912 Passed tests: 836 Skipped tests: 72 Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeRegionSecurityPolicyRule_EnforceOnKeyUpdates|TestAccComputeRegionSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs|TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions|TestAccComputeRegionSecurityPolicyRule_withRateLimit_withEnforceOnKeyConfigs

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionSecurityPolicyRule_EnforceOnKeyUpdates[Debug log] TestAccComputeRegionSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs[Debug log] TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions[Debug log] TestAccComputeRegionSecurityPolicyRule_withRateLimit_withEnforceOnKeyConfigs[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test