magic-modules
magic-modules copied to clipboard
Migrate certificate template to mmv1
Release Note Template for Downstream PRs (will be copied)
privateca: `google_privateca_certificate_template` now uses mmv1 engine instead of DCL
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_privateca_certificate_template
(14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_privateca_certificate_template
(14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2040 insertions(+), 1431 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_privateca_certificate_template
(14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
Tests analytics
Total tests: 3635
Passed tests: 3258
Skipped tests: 366
Affected tests: 11
Click here to see the affected service packages
all service packages are affected
Action taken
Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_withMaintenanceWindows|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update
Tests analytics
Total tests: 3635
Passed tests: 3259
Skipped tests: 366
Affected tests: 10
Click here to see the affected service packages
all service packages are affected
Action taken
Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update
Tests analytics
Total tests: 3635
Passed tests: 3258
Skipped tests: 366
Affected tests: 11
Click here to see the affected service packages
all service packages are affected
Action taken
Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample|TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccAlloydbCluster_withMaintenanceWindows
[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample
[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplateIamBindingGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample
[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample
[Debug log]
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
[Error message] [Debug log]
TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2038 insertions(+), 1429 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2038 insertions(+), 1429 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_privateca_certificate_template
(14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
Tests analytics
Total tests: 3629
Passed tests: 3261
Skipped tests: 366
Affected tests: 2
Click here to see the affected service packages
all service packages are affected
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate|TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificate_privatecaCertificateWithTemplateExample
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2055 insertions(+), 1429 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2055 insertions(+), 1429 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_privateca_certificate_template
(14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_privateca_certificate_template" "primary" {
maximum_lifetime = # value needed
}
Tests analytics
Total tests: 3630
Passed tests: 3263
Skipped tests: 366
Affected tests: 1
Click here to see the affected service packages
all service packages are affected
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2057 insertions(+), 1429 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2057 insertions(+), 1429 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Tests analytics
Total tests: 3630
Passed tests: 3261
Skipped tests: 366
Affected tests: 3
Click here to see the affected service packages
all service packages are affected
Action taken
Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy|TestAccHealthcareDatasetIamPolicy|TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
[Debug log]
TestAccHealthcareDatasetIamPolicy
[Debug log]
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplate
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Tests analytics
Total tests: 3632
Passed tests: 3265
Skipped tests: 366
Affected tests: 1
Click here to see the affected service packages
all service packages are affected
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
google-beta
provider: Diff ( 10 files changed, 2267 insertions(+), 1429 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 117 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Tests analytics
Total tests: 3632
Passed tests: 3265
Skipped tests: 366
Affected tests: 1
Click here to see the affected service packages
all service packages are affected
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm
[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Tests analytics
Total tests: 3632
Passed tests: 3265
Skipped tests: 366
Affected tests: 1
Click here to see the affected service packages
all service packages are affected
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplate_BasicCertificateTemplateLongForm
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 41 files changed, 2916 insertions(+), 1390 deletions(-))
google-beta
provider: Diff ( 41 files changed, 2916 insertions(+), 1390 deletions(-))
terraform-google-conversion
: Diff ( 1 file changed, 693 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
project
lost its diff suppress function - reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change
label can be added to allow merging.
Tests analytics
Total tests: 3646
Passed tests: 3268
Skipped tests: 371
Affected tests: 7
Click here to see the affected service packages
all service packages are affected
Action taken
Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccPrivatecaCertificateTemplateIamBindingGenerated|TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamMemberGenerated|TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition|TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccPrivatecaCertificateTemplateIamBindingGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamBindingGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamMemberGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated
[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated_withCondition
[Debug log]
TestAccPrivatecaCertificateTemplate_privatecaTemplateBasicExample
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test