Add autoscaling to DPMS terraform

[brandon-m-hansen]

This PR adds the scaling_config field to the google_dataproc_metastore_service beta resource. This PR fixes 17949 The autoscaling_config field enables the user to create a DPMS2 service with autoscaling enabled using Terraform.

If this PR is for Terraform, I acknowledge that I have:

• [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [x] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• [x] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [x] Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataprocmetastore: added `autoscaling_config` field to `google_dataproc_metastore_service` resource

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 182 insertions(+), 1 deletion(-)) google-beta provider: Diff ( 2 files changed, 182 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_service (22 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_service" "primary" {
  scaling_config {
    autoscaling_config {
      autoscaling_enabled = # value needed
      limit_config {
        max_scaling_factor = # value needed
        min_scaling_factor = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 14 Skipped tests: 2 Affected tests: 0

Click here to see the affected service packages

• dataprocmetastore

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 28 insertions(+)) google-beta provider: Diff ( 2 files changed, 181 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_service (22 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_service" "primary" {
  scaling_config {
    autoscaling_config {
      autoscaling_enabled = # value needed
      limit_config {
        max_scaling_factor = # value needed
        min_scaling_factor = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 14 Skipped tests: 2 Affected tests: 0

Click here to see the affected service packages

• dataprocmetastore

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 7 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions[bot]]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 352 insertions(+)) google-beta provider: Diff ( 3 files changed, 505 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+)) Open in Cloud Shell: Diff ( 16 files changed, 486 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataproc_metastore_service (22 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataproc_metastore_service" "primary" {
  scaling_config {
    autoscaling_config {
      autoscaling_enabled = # value needed
      limit_config {
        max_scaling_factor = # value needed
        min_scaling_factor = # value needed
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 20 Passed tests: 14 Skipped tests: 2 Affected tests: 4

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample[Error message] [Debug log] TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample[Error message] [Debug log] TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample[Error message] [Debug log] TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 352 insertions(+)) google-beta provider: Diff ( 3 files changed, 505 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+)) Open in Cloud Shell: Diff ( 16 files changed, 486 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20 Passed tests: 14 Skipped tests: 2 Affected tests: 4

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMaxScalingFactorExample[Debug log] TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinAndMaxScalingFactorExample[Debug log] TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingMinScalingFactorExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[github-actions[bot]]

@brandon-m-hansen, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 352 insertions(+)) google-beta provider: Diff ( 3 files changed, 506 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+)) Open in Cloud Shell: Diff ( 16 files changed, 486 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20 Passed tests: 17 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[github-actions[bot]]

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[brandon-m-hansen]

@NickElliot the test failed due to an internal DPMS error, it seems to be caused by the network quota being exceeded in the metastore terraform test project, so it should be unrelated to the new terraform fields

[NickElliot]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 352 insertions(+)) google-beta provider: Diff ( 3 files changed, 506 insertions(+), 1 deletion(-)) terraform-google-conversion: Diff ( 1 file changed, 71 insertions(+)) Open in Cloud Shell: Diff ( 16 files changed, 486 insertions(+))

[modular-magician]

Tests analytics

Total tests: 20 Passed tests: 17 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• dataprocmetastore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataprocMetastoreService_dataprocMetastoreServiceAutoscalingNoLimitConfigExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test