magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Alloydb: add support for PSC based clusters

Open simonebruzzechesse opened this issue 2 months ago • 3 comments

As per the PR title this PR adds support for PSC based Alloydb clusters, this is only supported in the google-beta provider since APIs are still in beta.

alloydb: added output field block `psc_instance_config` to `google_alloydb_instance ` resource
alloydb: added field block `psc_config` to `google_alloydb_cluster ` resource

simonebruzzechesse avatar Apr 24 '24 13:04 simonebruzzechesse

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 24 '24 13:04 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 109 insertions(+)) google-beta provider: Diff ( 6 files changed, 247 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_cluster (68 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_cluster" "primary" {
  psc_config {
    psc_enabled = # value needed
  }
}

Resource: google_alloydb_instance (66 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  psc_instance_config {
    allowed_consumer_projects = # value needed
    psc_dns_name              = # value needed
    service_attachment_link   = # value needed
  }
}

modular-magician avatar Apr 24 '24 19:04 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • alloydb

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Apr 24 '24 19:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 70 insertions(+)) google-beta provider: Diff ( 6 files changed, 262 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 29 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (78 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  psc_instance_config {
    allowed_consumer_projects = # value needed
    psc_dns_name              = # value needed
    service_attachment_link   = # value needed
  }
}

modular-magician avatar Apr 30 '24 17:04 modular-magician

Tests analytics

Total tests: 67 Passed tests: 61 Skipped tests: 4 Affected tests: 2

Click here to see the affected service packages
  • alloydb

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_withPSC|TestAccAlloydbInstance_createInstanceWithPSC

Get to know how VCR tests work

modular-magician avatar Apr 30 '24 17:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAlloydbCluster_withPSC[Error message] [Debug log] TestAccAlloydbInstance_createInstanceWithPSC[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 30 '24 17:04 modular-magician