magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add Compliance Config to the default cluster config field of the Fleet resource.

Open tonyzhc opened this issue 10 months ago • 19 comments

Add Compliance Config to the default cluster config field of the Fleet resource. Fixes b/330782787.

Release Note Template for Downstream PRs (will be copied)

gkehub2: added `compliance_config` field to `google_gke_hub_fleet` resource

tonyzhc avatar Apr 18 '24 23:04 tonyzhc

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+)) google-beta provider: Diff ( 3 files changed, 315 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

modular-magician avatar Apr 19 '24 00:04 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • gkehub2

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Apr 19 '24 00:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+)) google-beta provider: Diff ( 3 files changed, 315 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

modular-magician avatar Aug 26 '24 22:08 modular-magician

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Aug 26 '24 22:08 github-actions[bot]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • gkehub2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccGKEHub2Fleet_gkehubFleetWithComplianceConfig_update $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Aug 26 '24 22:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 315 insertions(+)) google-beta provider: Diff ( 3 files changed, 315 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 63 insertions(+))

modular-magician avatar Aug 26 '24 23:08 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • gkehub2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccGKEHub2Fleet_gkehubFleetWithComplianceConfig_update $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Aug 26 '24 23:08 modular-magician

@tonyzhc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Sep 10 '24 09:09 github-actions[bot]

@tonyzhc, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Sep 24 '24 09:09 github-actions[bot]

Hi @tonyzhc

Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: https://github.com/hashicorp/terraform-provider-google/issues/19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.

In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.

You also have the option to update the pull request yourself after the migration. You can view a preview branch and updated documentation related to the migration changes.

We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!

c2thorn avatar Sep 24 '24 20:09 c2thorn