magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add beta version to networkconnectivity.produc.yaml

Open simalcubuk opened this issue 10 months ago • 8 comments

Add beta api version to mmv1/products/networkconnectivity/product.yaml. This is needed to add RegionalEndpoint resource to magic-modules

Pbluc API doc for the new resource to be added: https://cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/v1beta/projects.locations.regionalEndpoints

If your PR is still work in progress, please create it in draft mode

This is not a breaking change, this change is only to enable adding a new resource in beta version.

simalcubuk avatar Apr 11 '24 14:04 simalcubuk

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 11 '24 14:04 github-actions[bot]

/gcbrun

simalcubuk avatar Apr 11 '24 15:04 simalcubuk

/gcbrun

hao-nan-li avatar Apr 11 '24 16:04 hao-nan-li

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 3 files changed, 5 insertions(+), 5 deletions(-)) terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Apr 11 '24 16:04 modular-magician

Tests analytics

Total tests: 3367 Passed tests: 2980 Skipped tests: 369 Affected tests: 18

Click here to see the affected service packages
all service packages are affected

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance|TestAccComputeRouterNat_withPrivateNatAndEmptyAction|TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges|TestAccComputeRouterNat_withPrivateNatAndRules|TestAccComputeRouterPeer_routerApplianceInstance|TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccNetworkConnectivityHub_BasicHub|TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteBasicExample|TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteFullExample|TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample|TestAccNetworkConnectivityServiceConnectionPolicy_update|TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten|TestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount|TestAccSqlUser_postgresIAM

Get to know how VCR tests work

modular-magician avatar Apr 11 '24 17:04 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRouterBgpPeer_routerPeerRouterAppliance[Debug log] TestAccComputeRouterNat_withPrivateNatAndEmptyAction[Debug log] TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges[Debug log] TestAccComputeRouterNat_withPrivateNatAndRules[Debug log] TestAccComputeRouterPeer_routerApplianceInstance[Debug log] TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log] TestAccNetworkConnectivityHub_BasicHub[Debug log] TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Debug log] TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteBasicExample[Error message] [Debug log] TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteFullExample[Error message] [Debug log] TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample[Error message] [Debug log] TestAccNetworkConnectivityServiceConnectionPolicy_update[Error message] [Debug log] TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log] TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log] TestAccRedisCluster_updateReplicaCount[Error message] [Debug log] TestAccRedisCluster_updateShardCount[Error message] [Debug log] TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 11 '24 17:04 modular-magician

re-roll as I will be on leave.

hao-nan-li avatar Apr 11 '24 21:04 hao-nan-li

It looks like the endpoints for some existing resources aren't in the beta version, causing test failures. Is there a plan to address this?

trodge avatar Apr 17 '24 22:04 trodge