magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add GKE Compliance configuration to cluster resource.

Open tonyzhc opened this issue 2 years ago • 4 comments

Add GKE Compliance enablement and configuration to cluster resource.

Note: the tests are passing with locally built client library, but the fields are not GA yet. Will send out for review once the fields are visible.

Release Note Template for Downstream PRs (will be copied)

container: added `compliance_config` field to `google_container_cluster` resource 

tonyzhc avatar Apr 05 '24 01:04 tonyzhc

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 288 insertions(+)) google-beta provider: Diff ( 2 files changed, 288 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar May 06 '24 23:05 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • container

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar May 06 '24 23:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 662 insertions(+), 348 deletions(-)) google-beta provider: Diff ( 2 files changed, 706 insertions(+), 415 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Aug 26 '24 22:08 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • container
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccContainerCluster_withComplianceConfig $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Aug 26 '24 22:08 modular-magician

Hi @tonyzhc

Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: https://github.com/hashicorp/terraform-provider-google/issues/19583 (or go/mm-migration-announcement if you are a Googler)

This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.

Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, but it seems like this change does not currently build correctly. I don't think our tooling would be able to correctly convert the pull request.

I see you are waiting for the fields to GA. I'd recommend opening a new pull request at that point with the new changes. Let me know if you have any questions

c2thorn avatar Sep 24 '24 20:09 c2thorn