magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add SecLM workbench

Open slevenick opened this issue 10 months ago • 3 comments

Release Note Template for Downstream PRs (will be copied)

`google_sec_lm_workbench`

slevenick avatar Apr 03 '24 16:04 slevenick

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 990 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 12 files changed, 980 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 76 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 108 insertions(+))

modular-magician avatar Apr 03 '24 16:04 modular-magician

Tests analytics

Total tests: 3553 Passed tests: 3181 Skipped tests: 368 Affected tests: 4

Click here to see the affected service packages
all service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccHealthcareDatasetIamPolicy|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccSecLMWorkbench_secLmWorkbenchBasicExample

Get to know how VCR tests work

modular-magician avatar Apr 03 '24 17:04 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log] TestAccHealthcareDatasetIamPolicy[Debug log] TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSecLMWorkbench_secLmWorkbenchBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 03 '24 17:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1000 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 12 files changed, 990 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 76 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 108 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sec_lm_workbench (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sec_lm_workbench" "primary" {
  project = # value needed
}

modular-magician avatar Apr 30 '24 16:04 modular-magician

Tests analytics

Total tests: 3631 Passed tests: 3264 Skipped tests: 366 Affected tests: 1

Click here to see the affected service packages
all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSecLMWorkbench_secLmWorkbenchBasicExample

Get to know how VCR tests work

modular-magician avatar Apr 30 '24 17:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSecLMWorkbench_secLmWorkbenchBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 30 '24 17:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1000 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 12 files changed, 990 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 76 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 108 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sec_lm_workbench (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sec_lm_workbench" "primary" {
  project = # value needed
}

modular-magician avatar Apr 30 '24 17:04 modular-magician

Tests analytics

Total tests: 3631 Passed tests: 3263 Skipped tests: 366 Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocJobIamPolicy|TestAccSecLMWorkbench_secLmWorkbenchBasicExample

Get to know how VCR tests work

modular-magician avatar Apr 30 '24 18:04 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataprocJobIamPolicy[Debug log] TestAccSecLMWorkbench_secLmWorkbenchBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Apr 30 '24 18:04 modular-magician

Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs last updated over 3 months ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.

rileykarson avatar Sep 06 '24 19:09 rileykarson