feat(spanner): Add InstanceConfig resource in Spanner product

[rahul2393]

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17632 b/211663511

Release Note Template for Downstream PRs (will be copied)

Add InstanceConfig resource in Spanner product

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[hao-nan-li]

/gcbrun

[hao-nan-li]

re-roll as I will be on leave.

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1009 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 1009 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 181 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Errors

google provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

• The diff processor failed to build. This is usually due to the downstream provider failing to compile.

[modular-magician]

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

• spanner

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1105 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 1105 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 231 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance_config (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance_config" "primary" {
  project = # value needed
  replicas {
    default_leader_location = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 28 Passed tests: 16 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages

• spanner

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[github-actions[bot]]

@rahul2393, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1118 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 1118 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Tests analytics

Total tests: 28 Passed tests: 16 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages

• spanner

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1217 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1217 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

[rahul2393]

@melinath Added the update test and validated everything. Please help review.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1217 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1217 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 16 Skipped tests: 13 Affected tests: 1

Click here to see the affected service packages

• spanner

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample
• TestAccSpannerInstanceConfig_update

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceConfig_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSpannerInstanceConfig_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 16 Skipped tests: 13 Affected tests: 1

Click here to see the affected service packages

• spanner

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample
• TestAccSpannerInstanceConfig_update

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceConfig_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSpannerInstanceConfig_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1217 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1217 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 16 Skipped tests: 13 Affected tests: 1

Click here to see the affected service packages

• spanner

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample
• TestAccSpannerInstanceConfig_update

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceConfig_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSpannerInstanceConfig_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1216 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1216 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 115 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 17 Skipped tests: 13 Affected tests: 0

Click here to see the affected service packages

• spanner

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample
• TestAccSpannerInstanceConfig_update

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1325 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1325 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 238 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30 Passed tests: 17 Skipped tests: 13 Affected tests: 0

Click here to see the affected service packages

• spanner

Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample
• TestAccSpannerInstanceConfig_update

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[melinath]

Note to self: Manually running tests in beta: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_SPANNER/159806?hideTestsFromDependencies=false&hideProblemsFromDependencies=false

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1293 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1293 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 238 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

[modular-magician]

Tests analytics

Total tests: 29 Passed tests: 16 Skipped tests: 11 Affected tests: 2

Click here to see the affected service packages

• spanner

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample|TestAccSpannerInstanceConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSpannerInstanceConfig_spannerInstanceConfigBasicExample[Debug log] TestAccSpannerInstanceConfig_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 1293 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 1293 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 238 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))