magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

feat(spanner): Add InstanceConfig resource in Spanner product

Open rahul2393 opened this issue 3 months ago • 8 comments

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17632 b/211663511

Release Note Template for Downstream PRs (will be copied)

Add InstanceConfig resource in Spanner product

rahul2393 avatar Apr 02 '24 05:04 rahul2393

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Apr 02 '24 05:04 github-actions[bot]

/gcbrun

hao-nan-li avatar Apr 02 '24 15:04 hao-nan-li

re-roll as I will be on leave.

hao-nan-li avatar Apr 11 '24 21:04 hao-nan-li

/gcbrun

melinath avatar Apr 12 '24 18:04 melinath

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1009 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 1009 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 181 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Apr 17 '24 06:04 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • spanner

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the build log

modular-magician avatar Apr 17 '24 07:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1105 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 1105 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 231 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 114 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_spanner_instance_config (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_spanner_instance_config" "primary" {
  project = # value needed
  replicas {
    default_leader_location = # value needed
  }
}

modular-magician avatar Apr 29 '24 05:04 modular-magician

Tests analytics

Total tests: 28 Passed tests: 16 Skipped tests: 12 Affected tests: 0

Click here to see the affected service packages
  • spanner

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar Apr 29 '24 05:04 modular-magician