magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

add autoscaled rollout policy for gke node pools

Open nvnmandadhi opened this issue 1 year ago • 10 comments

This PR adds a new feature to the GKE node pools, autoscaled rollout policy for blue green upgrade.

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [X] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X] Read Write release notes before writing my release note below.
release-note:enhancement

nvnmandadhi avatar Mar 28 '24 20:03 nvnmandadhi

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Mar 28 '24 20:03 github-actions[bot]

/gcbrun

trodge avatar Mar 28 '24 21:03 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 11 insertions(+)) google-beta provider: Diff ( 2 files changed, 91 insertions(+), 3 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Mar 28 '24 21:03 modular-magician

Tests analytics

Total tests: 188 Passed tests: 175 Skipped tests: 12 Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withUpgradeSettingsAutoscaledRolloutPolicy

Get to know how VCR tests work

modular-magician avatar Mar 28 '24 21:03 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccContainerNodePool_withUpgradeSettingsAutoscaledRolloutPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 28 '24 21:03 modular-magician

/gcbrun

trodge avatar Apr 01 '24 16:04 trodge

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+)) google-beta provider: Diff ( 2 files changed, 91 insertions(+), 3 deletions(-))

modular-magician avatar Apr 01 '24 16:04 modular-magician

Tests analytics

Total tests: 190 Passed tests: 177 Skipped tests: 12 Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerNodePool_withUpgradeSettingsAutoscaledRolloutPolicy

Get to know how VCR tests work

modular-magician avatar Apr 01 '24 16:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccContainerNodePool_withUpgradeSettingsAutoscaledRolloutPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 01 '24 16:04 modular-magician

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]

Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs last updated over 3 months ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.

rileykarson avatar Sep 06 '24 19:09 rileykarson