magic-modules
magic-modules copied to clipboard
GoogleCloudPlatform
Try removing VCR skip
VCR Skip is hiding test failures and I'm not sure why it is skipped for these resources
Fixes https://github.com/hashicorp/terraform-provider-google/issues/17699 or at least will eventually
Release Note Template for Downstream PRs (will be copied)
networksecurity: fixed an issue preventing successful create of `google_network_security_firewall_endpoint_association`
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google-beta provider: Diff ( 2 files changed, 2 deletions(-))
Tests analytics
Total tests: 36
Passed tests: 34
Skipped tests: 0
Affected tests: 2
Click here to see the affected service packages
- networksecurity
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkSecurityFirewallEndpointAssociations_basic|TestAccNetworkSecurityFirewallEndpoints_basic
Get to know how VCR tests work
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecurityFirewallEndpoints_basic[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkSecurityFirewallEndpointAssociations_basic[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google-beta provider: Diff ( 3 files changed, 1 insertion(+), 3 deletions(-))
Tests analytics
Total tests: 36
Passed tests: 35
Skipped tests: 0
Affected tests: 1
Click here to see the affected service packages
- networksecurity
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkSecurityFirewallEndpointAssociations_basic
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNetworkSecurityFirewallEndpointAssociations_basic[Error message] [Debug log]
$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test
Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs last updated over 3 months ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.
