magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update build-environment image to use Terraform 1.8.0

Open SarahFrench opened this issue 1 year ago • 2 comments

The intention of this change is to enable running provider-defined functions in VCR, as they're a new feature in 1.8.0

This PR is blocked until the GA release of Terraform 1.8.0. We're waiting for the GA release before making this change, instead of swapping to use a release candidate now and swapping to the GA release just a few weeks after.

Release Note Template for Downstream PRs (will be copied)


SarahFrench avatar Mar 26 '24 18:03 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Mar 26 '24 18:03 modular-magician

This is blocked until bugs in 1.8 are resolved

SarahFrench avatar Mar 27 '24 22:03 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar May 09 '24 20:05 modular-magician

This comment has some useful context about updating the version of Terraform used during testing: https://github.com/hashicorp/terraform-provider-google/issues/18109#issuecomment-2107736745

This PR is the final step for upgrading the Terraform version used for testing the provider. TeamCity is currently using 1.8.3 and the last step is making the automated tests on PRs use the same version.

SarahFrench avatar May 16 '24 14:05 SarahFrench

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 18 '24 09:05 github-actions[bot]

I realised that Scott is on vacation, so re-assigning review.

SarahFrench avatar May 20 '24 10:05 SarahFrench

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]