Add nfs support to cloudrun v1 services.

[bskaplan]

Support for NFS in v2 services was added in https://github.com/GoogleCloudPlatform/magic-modules/pull/9728, this adds it to v1.

Release Note Template for Downstream PRs (will be copied)

cloudrun: support nfs volumes (beta)

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[BBBmau]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 21 insertions(+)) google-beta provider: Diff ( 3 files changed, 233 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_service (49 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_service" "primary" {
  template {
    spec {
      volumes {
        nfs {
          read_only = # value needed
        }
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 21 insertions(+)) google-beta provider: Diff ( 3 files changed, 233 insertions(+)) terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_service (49 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_service" "primary" {
  template {
    spec {
      volumes {
        nfs {
          read_only = # value needed
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 29 Passed tests: 24 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

• cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_nfsVolume

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 29 Passed tests: 24 Skipped tests: 4 Affected tests: 1

Click here to see the affected service packages

• cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunService_nfsVolume

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccCloudRunService_nfsVolume[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccCloudRunService_nfsVolume[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[bskaplan]

It looks like it's not feasible to make a test right now that uses a VPC (it would require a 1 hour sleep and I don't feel comfortable adding that to the magic-modules test suite). I've asked the team to help make this faster, but can we merge this in the mean time and we'll add the test later?

[bskaplan]

@BBBmau can you approve? I don't think adding a 1 hour sleep in a test is worth it for this small of a change.