magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update min_cpu_platform to Intel Skylake for TestAccDataprocCluster_spotWithAuxiliaryNodeGroups

Open ahzaz opened this issue 11 months ago • 8 comments

Updated min_cpu_platform to Intel Skylake for TestAccDataprocCluster_spotWithAuxiliaryNodeGroups. n1-standard-2 is not compatible with cpu platform "AMD Rome"

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17534

Release Note Template for Downstream PRs (will be copied)

dataproc: Updated min_cpu_platform to Intel Skylake for TestAccDataprocCluster_spotWithAuxiliaryNodeGroups. n1-standard-2 is not compatible with cpu platform "AMD Rome".

ahzaz avatar Mar 20 '24 08:03 ahzaz

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Mar 20 '24 08:03 github-actions[bot]

@BBBmau Can you please help review and get this merged?

ahzaz avatar Mar 25 '24 00:03 ahzaz

/gcbrun

BBBmau avatar Mar 25 '24 01:03 BBBmau

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))

modular-magician avatar Mar 25 '24 01:03 modular-magician

Tests analytics

Total tests: 57 Passed tests: 51 Skipped tests: 5 Affected tests: 1

Click here to see the affected service packages
  • dataproc

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataprocCluster_spotWithAuxiliaryNodeGroups

Get to know how VCR tests work

modular-magician avatar Mar 25 '24 01:03 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataprocCluster_spotWithAuxiliaryNodeGroups[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 25 '24 02:03 modular-magician

@ahzaz error output from running tests:

2024/03/25 02:06:17 [DEBUG] [transport] [server-transport 0xc002e80820] loopyWriter exiting with error: transport closed by client 
    vcr_utils.go:152: Step 1/1 error: Error running apply: exit status 1
        
        Error: Error waiting for creating Dataproc cluster: Error code 13, message: Child createGceNodePool operations failed for the parent create operation: Operation(ci-test-project-188019/7562f3c7-731a-478e-9a2f-4e03d69b47f0)
        
          with google_dataproc_cluster.with_auxiliary_node_groups,
          on terraform_plugin_test.tf line 2, in resource "google_dataproc_cluster" "with_auxiliary_node_groups":
           2: resource "google_dataproc_cluster" "with_auxiliary_node_groups" {
        
        

may not be related, I'll take a more in-depth look tomorrow 👍🏼

BBBmau avatar Mar 25 '24 02:03 BBBmau

From Operation(ci-test-project-188019/7562f3c7-731a-478e-9a2f-4e03d69b47f0) mentioned in the previous comment:

"[skylake, nvidia-tesla-k80] features are not compatible for creating instance."

Harwayne avatar Mar 27 '24 19:03 Harwayne

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 5 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 05 '24 09:06 github-actions[bot]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 6 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 7 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

Closing this since the original issue was resolved by PR https://github.com/GoogleCloudPlatform/magic-modules/pull/10307

BBBmau avatar Jun 22 '24 00:06 BBBmau