magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Update labels.go to also check for user_labels

Open mikaelm12 opened this issue 11 months ago • 4 comments

Release Note Template for Downstream PRs (will be copied)


mikaelm12 avatar Mar 19 '24 23:03 mikaelm12

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Mar 19 '24 23:03 github-actions[bot]

to @zli82016 as it pertains to the labels update

NickElliot avatar Mar 20 '24 16:03 NickElliot

@mikaelm12 , I wonder what is the reason to check for user_labels.

The function SetLabelsDiff is only added as the CustomizeDiff to the resource with labels field and not added to the resource with user_labels field.

zli82016 avatar Mar 20 '24 16:03 zli82016

@mikaelm12 , do you have any questions before I closing this PR? Which resources do you expect to apply the function SetLabelsDiff?

zli82016 avatar Jul 30 '24 23:07 zli82016

Hey! I'm closing this PR as a part of a cleanup of older inactive PRs, using a threshold of PRs in "Draft" last updated over a month ago. This doesn't represent rejection of the change, and feel free to comment for me to reopen it if you plan to pick it back up, or feel free to start a new PR with the same changes in the future.

rileykarson avatar Sep 06 '24 19:09 rileykarson