Change load_balancer_type to optional in dns_record_set resource

[nbodepudi]

load_balancer_type is becoming optional to align with upcoming API changes. This change will introduce support for internal regional network proxy load balancers, as well as any other GCP load balancer that can be health checked.

b/290267743

Release Note Template for Downstream PRs (will be copied)

dns: change `load_balancer_type` field from required to optional

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 111 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 3 files changed, 111 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 46 Passed tests: 39 Skipped tests: 6 Affected tests: 1

Click here to see the affected service packages

• dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDNSRecordSet_routingPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[nbodepudi]

Hey, API changes are not in prod yet so the test is failing. Will make this PR a draft and reopen once they have landed.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 111 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 111 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (35 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup {
      backup_geo {
        health_checked_targets {
          internal_load_balancers {
            load_balancer_type = # value needed
          }
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 47 Passed tests: 45 Skipped tests: 1 Affected tests: 1

Click here to see the affected service packages

• dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDNSRecordSet_routingPolicy[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[nbodepudi]

Hi @slevenick, For some reason acceptance tests for GA provider are not running in my machine and it is throwing a weird error. I added a diff suppress func to fix this. I ran acceptance tests in beta, they were successful. Please take a look when you have time.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 3 files changed, 122 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (35 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup {
      backup_geo {
        health_checked_targets {
          internal_load_balancers {
            load_balancer_type = # value needed
          }
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 47 Passed tests: 45 Skipped tests: 1 Affected tests: 1

Click here to see the affected service packages

• dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDNSRecordSet_routingPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 125 insertions(+), 5 deletions(-)) google-beta provider: Diff ( 3 files changed, 125 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (35 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup {
      backup_geo {
        health_checked_targets {
          internal_load_balancers {
            load_balancer_type = # value needed
          }
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 47 Passed tests: 46 Skipped tests: 1 Affected tests: 0

Click here to see the affected service packages

• dns

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 148 insertions(+), 5 deletions(-)) google-beta provider: Diff ( 3 files changed, 148 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dns_record_set (35 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dns_record_set" "primary" {
  routing_policy {
    primary_backup {
      backup_geo {
        health_checked_targets {
          internal_load_balancers {
            load_balancer_type = # value needed
          }
        }
      }
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 47 Passed tests: 45 Skipped tests: 1 Affected tests: 1

Click here to see the affected service packages

• dns

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDNSRecordSet_routingPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDNSRecordSet_routingPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test