magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

creating a pull request to capture work on this

Open mike-callahan opened this issue 11 months ago • 3 comments

Fixes https://github.com/hashicorp/terraform-provider-google/issues/17516


mike-callahan avatar Mar 07 '24 19:03 mike-callahan

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Mar 07 '24 19:03 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Apr 22 '24 20:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar May 30 '24 03:05 modular-magician

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Jul 08 '24 03:07 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 226 insertions(+)) google-beta provider: Diff ( 4 files changed, 927 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jul 09 '24 06:07 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccComputeResizeRequest_computeMigResizeRequestExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Jul 09 '24 06:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 226 insertions(+)) google-beta provider: Diff ( 4 files changed, 927 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 139 insertions(+))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

modular-magician avatar Jul 09 '24 22:07 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccComputeResizeRequest_computeMigResizeRequestExample $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

modular-magician avatar Jul 09 '24 22:07 modular-magician

bug per askubis: ---[ REQUEST ]--------------------------------------- 2024-07-09T11:42:30.388Z [DEBUG] provider.terraform-provider-google-beta: DELETE /compute/beta/projects/estest0/zones/us-central1-a/instanceGroupManagers/a3-dws/resizeRequests/?alt=json HTTP/1.1

mike-callahan avatar Jul 09 '24 22:07 mike-callahan

bug per askubis: ---[ REQUEST ]--------------------------------------- 2024-07-09T11:42:30.388Z [DEBUG] provider.terraform-provider-google-beta: DELETE /compute/beta/projects/estest0/zones/us-central1-a/instanceGroupManagers/a3-dws/resizeRequests/?alt=json HTTP/1.1

fixed

mike-callahan avatar Jul 09 '24 22:07 mike-callahan

if d.Get("state") == "ACCEPTED" does not return true

fixed

mike-callahan avatar Jul 09 '24 22:07 mike-callahan

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 223 insertions(+)) google-beta provider: Diff ( 4 files changed, 883 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  resize_request = # value needed
}


modular-magician avatar Jul 09 '24 22:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 223 insertions(+)) google-beta provider: Diff ( 4 files changed, 883 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  resize_request = # value needed
}


modular-magician avatar Jul 09 '24 22:07 modular-magician

Tests analytics

Total tests: 967 Passed tests: 891 Skipped tests: 73 Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

modular-magician avatar Jul 09 '24 22:07 modular-magician

Tests analytics

Total tests: 967 Passed tests: 892 Skipped tests: 73 Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

modular-magician avatar Jul 09 '24 22:07 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeResizeRequest_computeMigResizeRequestExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 09 '24 23:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeResizeRequest_computeMigResizeRequestExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 09 '24 23:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 896 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 896 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  resize_request = # value needed
}


modular-magician avatar Jul 10 '24 23:07 modular-magician

Tests analytics

Total tests: 967 Passed tests: 892 Skipped tests: 73 Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

modular-magician avatar Jul 10 '24 23:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 896 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 896 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  resize_request = # value needed
}


modular-magician avatar Jul 10 '24 23:07 modular-magician

Tests analytics

Total tests: 967 Passed tests: 892 Skipped tests: 73 Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

modular-magician avatar Jul 10 '24 23:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeResizeRequest_computeMigResizeRequestExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 10 '24 23:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 885 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 885 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

modular-magician avatar Jul 11 '24 00:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeResizeRequest_computeMigResizeRequestExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 11 '24 00:07 modular-magician

Tests analytics

Total tests: 967 Passed tests: 892 Skipped tests: 73 Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

modular-magician avatar Jul 11 '24 00:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccComputeResizeRequest_computeMigResizeRequestExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 11 '24 01:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1974 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 1974 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  status {
    error {
      errors {
        code = # value needed
        error_details {
          error_info {
            domain    = # value needed
            metadatas = # value needed
            reason    = # value needed
          }
          help {
            links {
              description = # value needed
              url         = # value needed
            }
          }
          localized_message {
            locale  = # value needed
            message = # value needed
          }
          quota_info {
            dimensions     = # value needed
            future_limit   = # value needed
            limit          = # value needed
            limit_name     = # value needed
            metric_name    = # value needed
            rollout_status = # value needed
          }
        }
        location = # value needed
        message  = # value needed
      }
    }
    last_attempt {
      error {
        errors {
          code = # value needed
          error_details {
            error_info {
              domain    = # value needed
              metadatas = # value needed
              reason    = # value needed
            }
            help {
              links {
                description = # value needed
                url         = # value needed
              }
            }
            localized_message {
              locale  = # value needed
              message = # value needed
            }
            quota_info {
              dimensions     = # value needed
              future_limit   = # value needed
              limit          = # value needed
              limit_name     = # value needed
              metric_name    = # value needed
              rollout_status = # value needed
            }
          }
          location = # value needed
          message  = # value needed
        }
      }
    }
  }
}


modular-magician avatar Jul 11 '24 01:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1974 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 1974 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  status {
    error {
      errors {
        code = # value needed
        error_details {
          error_info {
            domain    = # value needed
            metadatas = # value needed
            reason    = # value needed
          }
          help {
            links {
              description = # value needed
              url         = # value needed
            }
          }
          localized_message {
            locale  = # value needed
            message = # value needed
          }
          quota_info {
            dimensions     = # value needed
            future_limit   = # value needed
            limit          = # value needed
            limit_name     = # value needed
            metric_name    = # value needed
            rollout_status = # value needed
          }
        }
        location = # value needed
        message  = # value needed
      }
    }
    last_attempt {
      error {
        errors {
          code = # value needed
          error_details {
            error_info {
              domain    = # value needed
              metadatas = # value needed
              reason    = # value needed
            }
            help {
              links {
                description = # value needed
                url         = # value needed
              }
            }
            localized_message {
              locale  = # value needed
              message = # value needed
            }
            quota_info {
              dimensions     = # value needed
              future_limit   = # value needed
              limit          = # value needed
              limit_name     = # value needed
              metric_name    = # value needed
              rollout_status = # value needed
            }
          }
          location = # value needed
          message  = # value needed
        }
      }
    }
  }
}


modular-magician avatar Jul 11 '24 01:07 modular-magician

Tests analytics

Total tests: 967 Passed tests: 892 Skipped tests: 73 Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

modular-magician avatar Jul 11 '24 01:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 1974 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 4 files changed, 1974 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 171 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_resize_request (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_resize_request" "primary" {
  status {
    error {
      errors {
        code = # value needed
        error_details {
          error_info {
            domain    = # value needed
            metadatas = # value needed
            reason    = # value needed
          }
          help {
            links {
              description = # value needed
              url         = # value needed
            }
          }
          localized_message {
            locale  = # value needed
            message = # value needed
          }
          quota_info {
            dimensions     = # value needed
            future_limit   = # value needed
            limit          = # value needed
            limit_name     = # value needed
            metric_name    = # value needed
            rollout_status = # value needed
          }
        }
        location = # value needed
        message  = # value needed
      }
    }
    last_attempt {
      error {
        errors {
          code = # value needed
          error_details {
            error_info {
              domain    = # value needed
              metadatas = # value needed
              reason    = # value needed
            }
            help {
              links {
                description = # value needed
                url         = # value needed
              }
            }
            localized_message {
              locale  = # value needed
              message = # value needed
            }
            quota_info {
              dimensions     = # value needed
              future_limit   = # value needed
              limit          = # value needed
              limit_name     = # value needed
              metric_name    = # value needed
              rollout_status = # value needed
            }
          }
          location = # value needed
          message  = # value needed
        }
      }
    }
  }
}


modular-magician avatar Jul 11 '24 01:07 modular-magician