Add Private Cloud Sweepers for southamerica-west1

[swamitagupta]

Vmwareengine Private Cloud tests run in the location southamerica-west1-a. This is because these tests require provisioning multiple nodes and southamerica-west1 region has low utilisation.

Since sweepers only clean up us-central1 resources, this PR adds a handwritten sweeper cleaning up the dandling private clouds and is an intended fix for b/326669990

Release Note Template for Downstream PRs (will be copied)

[github-actions[bot]]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 131 insertions(+), 74 deletions(-)) Terraform Beta: Diff ( 4 files changed, 131 insertions(+), 74 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 13 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• vmwareengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

[shuyama1]

Triggered TestAccVmwareengineCluster_vmwareEngineClusterUpdate on TC at https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_VMWAREENGINE/115281?hideTestsFromDependencies=false&hideProblemsFromDependencies=false since it's skipped in VCR. Will update the result when the test completes

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 131 insertions(+), 52 deletions(-)) Terraform Beta: Diff ( 4 files changed, 131 insertions(+), 52 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 13 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• vmwareengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 131 insertions(+), 53 deletions(-)) Terraform Beta: Diff ( 4 files changed, 131 insertions(+), 53 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 13 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• vmwareengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 131 insertions(+), 78 deletions(-)) Terraform Beta: Diff ( 4 files changed, 131 insertions(+), 78 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 13 Skipped tests: 2 Affected tests: 1

Click here to see the affected service packages

• vmwareengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVmwareengineExternalAddress_vmwareEngineExternalAddressUpdate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 131 insertions(+), 79 deletions(-)) Terraform Beta: Diff ( 4 files changed, 131 insertions(+), 79 deletions(-))

[modular-magician]

Tests analytics

Total tests: 16 Passed tests: 14 Skipped tests: 2 Affected tests: 0

Click here to see the affected service packages

• vmwareengine

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[shuyama1]

Running test on TC: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_VMWAREENGINE/117356?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true

[swamitagupta]

Test TestAccVmwareengineCluster_vmwareEngineClusterUpdate failed with error:

vcr_utils.go:152: Step 1/6 error: Error running apply: exit status 1
        Error: Error waiting to create PrivateCloud: Error waiting for Creating PrivateCloud: Error code 13, message: an internal error has occurred
          with google_vmwareengine_private_cloud.cluster-pc,
          on terraform_plugin_test.tf line 10, in resource "google_vmwareengine_private_cloud" "cluster-pc":
          10: resource "google_vmwareengine_private_cloud" "cluster-pc" {
--- FAIL: TestAccVmwareengineCluster_vmwareEngineClusterUpdate (126.40s)

Looks like it is failing with the internal error Private cloud creation failed, no available nodes. @shuyama1 could you please verify that the project being used to run the test has at least 7 nodes available in the southamerica-west1 region, and that it does not contain any dangling Private Clouds?

[github-actions[bot]]

@swamitagupta, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@swamitagupta, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@swamitagupta, this PR is being closed due to inactivity.