magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add lb traffic extension resource

Open maxi-cit opened this issue 11 months ago • 16 comments

Adds the new google_network_services_lb_traffic_extension resource.

Part of: https://github.com/hashicorp/terraform-provider-google/issues/17491 Fixes: https://github.com/hashicorp/terraform-provider-google/issues/17373

Release Note Template for Downstream PRs (will be copied)

`google_network_services_lb_traffic_extension`

maxi-cit avatar Mar 05 '24 15:03 maxi-cit

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Mar 05 '24 15:03 github-actions[bot]

Hey @NickElliot I am still waiting for the API to become GA in order to validate the tests

PD: they told they are releasing it in the comming weeks

maxi-cit avatar Mar 07 '24 14:03 maxi-cit

/gcbrun

NickElliot avatar Mar 08 '24 22:03 NickElliot

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 430 insertions(+)) Terraform Beta: Diff ( 5 files changed, 1768 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_traffic_extension (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_traffic_extension" "primary" {
  description = # value needed
  extension_chains {
    extensions {
      fail_open       = # value needed
      forward_headers = # value needed
    }
  }
  labels = # value needed
}

modular-magician avatar Mar 08 '24 22:03 modular-magician

Tests analytics

Total tests: 47 Passed tests: 46 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

Get to know how VCR tests work

modular-magician avatar Mar 08 '24 22:03 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 08 '24 22:03 modular-magician

/gcbrun

NickElliot avatar Apr 05 '24 16:04 NickElliot

Hello @NickElliot, still working on adding integration tests but I should be able to push some of them today for traffic and route extensions

maxi-cit avatar Apr 05 '24 16:04 maxi-cit

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 1766 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 5 files changed, 1766 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 313 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_traffic_extension (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_traffic_extension" "primary" {
  description = # value needed
  extension_chains {
    extensions {
      fail_open       = # value needed
      forward_headers = # value needed
    }
  }
  labels = # value needed
}

modular-magician avatar Apr 05 '24 16:04 modular-magician

Tests analytics

Total tests: 47 Passed tests: 46 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

Get to know how VCR tests work

modular-magician avatar Apr 05 '24 16:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 05 '24 16:04 modular-magician

All good, ping me when you have them ready @maxi-cit

NickElliot avatar Apr 09 '24 22:04 NickElliot

Also in case it resolves the current VCR error, could you rebase? Thanks!

NickElliot avatar Apr 09 '24 22:04 NickElliot

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 430 insertions(+)) google-beta provider: Diff ( 5 files changed, 1782 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_traffic_extension (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_traffic_extension" "primary" {
  description      = # value needed
  effective_labels = # value needed
  extension_chains = # value needed
  extension_chains {
    extensions = # value needed
    extensions {
      fail_open       = # value needed
      forward_headers = # value needed
    }
    match_condition = # value needed
  }
  labels           = # value needed
  project          = # value needed
  terraform_labels = # value needed
}

modular-magician avatar Apr 16 '24 20:04 modular-magician

Tests analytics

Total tests: 47 Passed tests: 46 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

Get to know how VCR tests work

modular-magician avatar Apr 16 '24 20:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Apr 16 '24 20:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 525 insertions(+)) google-beta provider: Diff ( 5 files changed, 1972 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_services_lb_traffic_extension (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_services_lb_traffic_extension" "primary" {
  description = # value needed
  extension_chains {
    extensions {
      forward_headers = # value needed
    }
  }
  labels  = # value needed
  project = # value needed
}

modular-magician avatar May 01 '24 20:05 modular-magician

Tests analytics

Total tests: 47 Passed tests: 46 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

Get to know how VCR tests work

modular-magician avatar May 01 '24 20:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar May 01 '24 20:05 modular-magician

Any update on this?

rshriram avatar May 02 '24 14:05 rshriram

Hello @NickElliot, is there anything left?

maxi-cit avatar May 02 '24 14:05 maxi-cit

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 537 insertions(+)) google-beta provider: Diff ( 5 files changed, 1999 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

modular-magician avatar May 08 '24 22:05 modular-magician

Tests analytics

Total tests: 47 Passed tests: 46 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

Get to know how VCR tests work

modular-magician avatar May 08 '24 22:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar May 08 '24 22:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 1282 insertions(+)) google-beta provider: Diff ( 6 files changed, 2744 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+))

modular-magician avatar May 09 '24 16:05 modular-magician

Tests analytics

Total tests: 48 Passed tests: 47 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_update

Get to know how VCR tests work

modular-magician avatar May 09 '24 16:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccNetworkServicesLbTrafficExtension_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar May 09 '24 16:05 modular-magician

Hello @NickElliot, I removed the beta annotation from the mmv1 specification. According to this doc. This is also available in GA.

maxi-cit avatar May 09 '24 21:05 maxi-cit

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 2742 insertions(+), 2 deletions(-)) google-beta provider: Diff ( 6 files changed, 2742 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 267 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 421 insertions(+))

modular-magician avatar May 09 '24 21:05 modular-magician

Tests analytics

Total tests: 48 Passed tests: 47 Skipped tests: 0 Affected tests: 1

Click here to see the affected service packages
  • networkservices

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkServicesLbTrafficExtension_networkServicesLbTrafficExtensionBasicExample

Get to know how VCR tests work

modular-magician avatar May 09 '24 21:05 modular-magician