magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Create support for KMS Ekmconnection resource

Open rishamchokshi opened this issue 11 months ago • 30 comments

This PR consists of adding a new resource to kms service called ekm_connection. Ekm_connection resource is used for external key management.

Bug tickets: b/312739028

Release Note Template for Downstream PRs (will be copied)

`google_kms_ekm_connection`

rishamchokshi avatar Feb 29 '24 19:02 rishamchokshi

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 29 '24 19:02 github-actions[bot]

/gcbrun

c2thorn avatar Feb 29 '24 19:02 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1065 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1065 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 19:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 20:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 20:02 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1065 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1065 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 20:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 20:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 20:02 modular-magician

/gcbrun

c2thorn avatar Feb 29 '24 20:02 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1065 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1065 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 20:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 20:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 20:02 modular-magician

/gcbrun

c2thorn avatar Feb 29 '24 21:02 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1067 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1067 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 21:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 21:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 21:02 modular-magician

/gcbrun

c2thorn avatar Feb 29 '24 21:02 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1077 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1077 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 21:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 21:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 21:02 modular-magician

/gcbrun

c2thorn avatar Feb 29 '24 22:02 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1077 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1077 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 22:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 22:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 22:02 modular-magician

/gcbrun

c2thorn avatar Feb 29 '24 22:02 c2thorn

/gcbrun

c2thorn avatar Feb 29 '24 22:02 c2thorn

/gcbrun

c2thorn avatar Feb 29 '24 22:02 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 1114 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 1114 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 274 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_kms_ekm_connection (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_kms_ekm_connection" "primary" {
  etag = # value needed
  service_resolvers {
    endpoint_filter = # value needed
    server_certificates {
      subject_alternative_dns_names = # value needed
    }
  }
}

modular-magician avatar Feb 29 '24 23:02 modular-magician

Tests analytics

Total tests: 30 Passed tests: 26 Skipped tests: 3 Affected tests: 1

Click here to see the affected service packages
  • kms

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 23:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 23:02 modular-magician