magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add new resource for Application for Apphub

Open eshagoel06 opened this issue 1 year ago • 5 comments

FIXES https://github.com/hashicorp/terraform-provider-google/issues/17448

Release Note Template for Downstream PRs (will be copied)

google_apphub_application

eshagoel06 avatar Feb 28 '24 17:02 eshagoel06

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 29 '24 06:02 github-actions[bot]

/gcbrun

slevenick avatar Feb 29 '24 15:02 slevenick

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 1971 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 13 files changed, 1971 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 318 insertions(+)) TF OiCS: Diff ( 8 files changed, 256 insertions(+))

modular-magician avatar Feb 29 '24 15:02 modular-magician

Tests analytics

Total tests: 3483 Passed tests: 3127 Skipped tests: 353 Affected tests: 3

Click here to see the affected service packages
all service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccApphubApplication_applicationBasicExample|TestAccApphubApplication_applicationFullExample|TestAccApphubApplication_applicationUpdateFull

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 16:02 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccApphubApplication_applicationBasicExample[Debug log] TestAccApphubApplication_applicationFullExample[Debug log] TestAccApphubApplication_applicationUpdateFull[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 16:02 modular-magician

/gcbrun

slevenick avatar Mar 04 '24 14:03 slevenick

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1981 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 13 files changed, 1971 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 318 insertions(+)) TF OiCS: Diff ( 8 files changed, 256 insertions(+))

modular-magician avatar Mar 04 '24 14:03 modular-magician

Tests analytics

Total tests: 3485 Passed tests: 3132 Skipped tests: 353 Affected tests: 0

Click here to see the affected service packages
all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar Mar 04 '24 15:03 modular-magician

/gcbrun

slevenick avatar Mar 05 '24 19:03 slevenick

/gcbrun

slevenick avatar Mar 05 '24 22:03 slevenick

/gcbrun

slevenick avatar Mar 06 '24 13:03 slevenick

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 15 files changed, 1932 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 13 files changed, 1922 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 318 insertions(+)) TF OiCS: Diff ( 8 files changed, 238 insertions(+))

modular-magician avatar Mar 06 '24 14:03 modular-magician

Tests analytics

Total tests: 3487 Passed tests: 3132 Skipped tests: 353 Affected tests: 2

Click here to see the affected service packages
all service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleServiceAccountIdToken_impersonation|TestAccDefaultUniverseDomain_doesNotMatchExplicit

Get to know how VCR tests work

modular-magician avatar Mar 06 '24 15:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataSourceGoogleServiceAccountIdToken_impersonation[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDefaultUniverseDomain_doesNotMatchExplicit[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 06 '24 15:03 modular-magician