magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Add `region_from_zone` provider function

Open BBBmau opened this issue 1 year ago • 7 comments

Implement a provider function that lets users get the region from a zone, e.g. get “us-central1” from “us-central1-a”.

We need to decide how the function responds to ‘bad' input and document this in automated tests.

Examples of bad input:

  • empty string

  • string of an inappropriate string like “foobar”

  • string of a region, when a zone is expected

Acceptance Criteria

  • [X] Provider function is implemented
  • [x] Unit tests cover the function’s logic
  • [x] Appropriate levels of acceptance tests added
  • [x] Copy for documentation created

Release Note Template for Downstream PRs (will be copied)


BBBmau avatar Feb 28 '24 05:02 BBBmau

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 9 files changed, 532 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 9 files changed, 532 insertions(+), 4 deletions(-))

modular-magician avatar Feb 28 '24 05:02 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 747 insertions(+), 4 deletions(-)) Terraform Beta: Diff ( 12 files changed, 747 insertions(+), 4 deletions(-))

modular-magician avatar Feb 28 '24 06:02 modular-magician

Tests analytics

Total tests: 3462 Passed tests: 3082 Skipped tests: 350 Affected tests: 30

Click here to see the affected service packages
all service packages are affected

Action taken

Found 30 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample|TestAccComposerEnvironmentComposer3_basic|TestAccComposerEnvironmentComposer3_update|TestAccComposerEnvironmentComposer3_updateFromEmpty|TestAccComposerEnvironmentComposer3_updateToEmpty|TestAccComputeRegionTargetTcpProxy_update|TestAccContainerCluster_withGatewayApiConfig|TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamPolicyGenerated|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2Scope_gkehubScopeBasicExample_update|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccNotebooksRuntime_update

Get to know how VCR tests work

modular-magician avatar Feb 28 '24 07:02 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample[Debug log] TestAccComposerEnvironmentComposer3_basic[Debug log] TestAccComposerEnvironmentComposer3_update[Debug log] TestAccComposerEnvironmentComposer3_updateFromEmpty[Debug log] TestAccComposerEnvironmentComposer3_updateFromEmpty[Debug log] TestAccComposerEnvironmentComposer3_updateToEmpty[Debug log] TestAccComposerEnvironmentComposer3_updateToEmpty[Debug log] TestAccComputeRegionTargetTcpProxy_update[Debug log] TestAccGKEHub2ScopeIamBindingGenerated[Debug log] TestAccGKEHub2ScopeIamMemberGenerated[Debug log] TestAccGKEHub2ScopeIamPolicyGenerated[Debug log] TestAccGKEHub2Scope_gkehubScopeBasicExample[Debug log] TestAccGKEHub2Scope_gkehubScopeBasicExample_update[Debug log] TestAccGKEHub2Scope_gkehubScopeBasicExample_update[Debug log] TestAccNotebooksRuntime_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Error message] [Debug log] TestAccContainerCluster_withGatewayApiConfig[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 28 '24 09:02 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 269 insertions(+)) Terraform Beta: Diff ( 5 files changed, 269 insertions(+))

modular-magician avatar Feb 28 '24 21:02 modular-magician

Tests analytics

Total tests: 3462 Passed tests: 3093 Skipped tests: 350 Affected tests: 19

Click here to see the affected service packages
all service packages are affected

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccContainerCluster_withGatewayApiConfig|TestAccDataprocClusterIamPolicy|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition

Get to know how VCR tests work

modular-magician avatar Feb 28 '24 22:02 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDataprocClusterIamPolicy[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Error message] [Debug log] TestAccContainerCluster_withGatewayApiConfig[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 28 '24 22:02 modular-magician

After reviewing: https://github.com/GoogleCloudPlatform/magic-modules/pull/10061

I went ahead and used the same tf config for testing since it's a much shorter setup time than the one i had prior. However I'm running into an issue when running the test despite the testconfig being identical.

region_from_zone test output

└─(01:05:46 on main ✹ ✭)──> envchain GCLOUD make testacc TEST=./google/functions TESTARGS='-run=TestAccProviderFunction_region_from_zone'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/functions -v -run=TestAccProviderFunction_region_from_zone -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccProviderFunction_region_from_zone
=== PAUSE TestAccProviderFunction_region_from_zone
=== CONT  TestAccProviderFunction_region_from_zone
    vcr_utils.go:152: Step 1/1 error: Error running apply: exit status 1
        
        Error: Error creating Service: googleapi: got HTTP response code 404 with body: <!DOCTYPE html>
        <html lang=en>
          <meta charset=utf-8>
          <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
          <title>Error 404 (Not Found)!!1</title>
          <style>
            *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
          </style>
          <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
          <p><b>404.</b> <ins>That’s an error.</ins>
          <p>The requested URL <code>/apis/serving.knative.dev/v1/namespaces/hc-terraform-testing/services</code> was not found on this server.  <ins>That’s all we know.</ins>
        
        
          with google_cloud_run_service.default,
          on terraform_plugin_test.tf line 11, in resource "google_cloud_run_service" "default":
          11: resource "google_cloud_run_service" "default" {
        
--- FAIL: TestAccProviderFunction_region_from_zone (4.96s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-google/google/functions 5.952s
FAIL
make: *** [testacc] Error 1

location_from_id test output

┌─(~/Dev/terraform-provider-google)───────────────────────────────────────────────────────────────────────────────────(mau@mau-JKDT676NCP:s037)─┐
└─(01:06:51 on main ✹ ✭)──> envchain GCLOUD make testacc TEST=./google/functions TESTARGS='-run=TestAccProviderFunction_location_from_id'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/functions -v -run=TestAccProviderFunction_location_from_id -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccProviderFunction_location_from_id
=== PAUSE TestAccProviderFunction_location_from_id
=== CONT  TestAccProviderFunction_location_from_id
--- PASS: TestAccProviderFunction_location_from_id (27.84s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/functions 28.804s

BBBmau avatar Mar 01 '24 09:03 BBBmau

I went ahead and used the same tf config for testing since it's a much shorter setup time than the one i had prior. However I'm running into an issue when running the test despite the testconfig being identical.

@BBBmau I think the problem is that the resource cannot take a zone as the location value? When I re-wrote the test to use the v2 version of the cloud run service resource I got this error Error: Error creating Service: googleapi: Error 403: Permission denied on 'locations/us-central1-a' (or it may not exist)

Try provisioning a zonal resource in the acceptance test for this function, e.g. a persistent disk

SarahFrench avatar Mar 01 '24 14:03 SarahFrench

/gcbrun

BBBmau avatar Mar 01 '24 18:03 BBBmau

This PR looks good to go! I'm going to wait for the Diff Report to be posted, which means the auto-pr-10073 branch in the MM fork Google provider will reflect your latest changes. I'll then run the acceptance tests in my new testing setup in TeamCity I've made 😎

SarahFrench avatar Mar 01 '24 18:03 SarahFrench

I think we might be experiencing problems due to the change in tokens used for automation 😭

Let's save merging this until next week!

SarahFrench avatar Mar 01 '24 19:03 SarahFrench

Trying one last /gcbrun

SarahFrench avatar Mar 07 '24 15:03 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 282 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 5 files changed, 282 insertions(+), 1 deletion(-))

modular-magician avatar Mar 07 '24 16:03 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 282 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 5 files changed, 282 insertions(+), 1 deletion(-))

modular-magician avatar Mar 07 '24 16:03 modular-magician

Tests analytics

Total tests: 3465 Passed tests: 3073 Skipped tests: 350 Affected tests: 42

Click here to see the affected service packages
all service packages are affected

Action taken

Found 42 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_buildworkerpool|TestAccCloudFunctionsFunction_update|TestAccComputeBackendService_regionNegBackend|TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetFqdnPortExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetIpPortExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetFqdnPortExample|TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetIpPortExample|TestAccContainerCluster_withGatewayApiConfig|TestAccDataSourceRegionNetworkEndpointGroup_basic|TestAccDefaultUniverseDomain_doesNotMatchExplicit|TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccProviderFunction_location_from_id|TestAccProviderFunction_project_from_id|TestAccProviderFunction_region_from_zone|TestAccRegionInstanceGroupManager_update|TestAccSecurityposturePosture_securityposturePostureBasicExample

Get to know how VCR tests work

modular-magician avatar Mar 07 '24 18:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccCloudFunctionsFunction_basic[Debug log] TestAccCloudFunctionsFunction_buildworkerpool[Debug log] TestAccCloudFunctionsFunction_update[Debug log] TestAccComputeBackendService_regionNegBackend[Debug log] TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetFqdnPortExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetIpPortExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log] TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetFqdnPortExample[Debug log] TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetIpPortExample[Debug log] TestAccDataSourceRegionNetworkEndpointGroup_basic[Debug log] TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample[Debug log] TestAccInstanceGroupManager_update[Debug log] TestAccInstanceGroupManager_waitForStatus[Debug log] TestAccRegionInstanceGroupManager_update[Debug log] TestAccSecurityposturePosture_securityposturePostureBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Error message] [Debug log] TestAccContainerCluster_withGatewayApiConfig[Error message] [Debug log] TestAccDefaultUniverseDomain_doesNotMatchExplicit[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccProviderFunction_location_from_id[Error message] [Debug log] TestAccProviderFunction_project_from_id[Error message] [Debug log] TestAccProviderFunction_region_from_zone[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 07 '24 18:03 modular-magician

We can solve the VCR failures by me syncing main into the FEATURE-BRANCH-provider-functions branch with this PR (currently blocked) : https://github.com/GoogleCloudPlatform/magic-modules/pull/10138

SarahFrench avatar Mar 07 '24 23:03 SarahFrench

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 283 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 5 files changed, 283 insertions(+), 1 deletion(-))

modular-magician avatar Mar 08 '24 14:03 modular-magician

Tests analytics

Total tests: 3465 Passed tests: 3092 Skipped tests: 351 Affected tests: 22

Click here to see the affected service packages
all service packages are affected

Action taken

Found 22 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample|TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample|TestAccAppEngineServiceNetworkSettings_update|TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample|TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample|TestAccContainerCluster_withGatewayApiConfig|TestAccDefaultUniverseDomain_doesNotMatchExplicit|TestAccIapAppEngineServiceIamBindingGenerated|TestAccIapAppEngineServiceIamBindingGenerated_withCondition|TestAccIapAppEngineServiceIamMemberGenerated|TestAccIapAppEngineServiceIamMemberGenerated_withCondition|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated_withCondition|TestAccIapAppEngineVersionIamBindingGenerated|TestAccIapAppEngineVersionIamBindingGenerated_withCondition|TestAccIapAppEngineVersionIamMemberGenerated|TestAccIapAppEngineVersionIamMemberGenerated_withCondition|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccIapAppEngineVersionIamPolicyGenerated_withCondition|TestAccProviderFunction_location_from_id|TestAccProviderFunction_project_from_id|TestAccStorageBucket_lifecycleRulesNoAge

Get to know how VCR tests work

modular-magician avatar Mar 08 '24 15:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccStorageBucket_lifecycleRulesNoAge[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineApplicationUrlDispatchRules_appEngineApplicationUrlDispatchRulesBasicExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_appEngineServiceNetworkSettingsExample[Error message] [Debug log] TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log] TestAccAppEngineServiceSplitTraffic_appEngineServiceSplitTrafficExample[Error message] [Debug log] TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionExample[Error message] [Debug log] TestAccContainerCluster_withGatewayApiConfig[Error message] [Debug log] TestAccDefaultUniverseDomain_doesNotMatchExplicit[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineServiceIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamBindingGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamMemberGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccIapAppEngineVersionIamPolicyGenerated_withCondition[Error message] [Debug log] TestAccProviderFunction_location_from_id[Error message] [Debug log] TestAccProviderFunction_project_from_id[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 08 '24 16:03 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 283 insertions(+)) Terraform Beta: Diff ( 5 files changed, 283 insertions(+))

modular-magician avatar Mar 08 '24 19:03 modular-magician

Now the tests have run there's an obvious problem:

--- FAIL: TestAccProviderFunction_region_from_zone (0.00s)
panic: runtime error: slice bounds out of range [:-2] [recovered]
	panic: runtime error: slice bounds out of range [:-2]

goroutine 45 [running]:
testing.tRunner.func1.2({0x3db8a00, 0xc0004d00c0})
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:[16](https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/8191213673/job/22399923645#step:8:17)31 +0x24a
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:1634 +0x377
panic({0x3db8a00?, 0xc0004d00c0?})
	/opt/hostedtoolcache/go/1.22.0/x64/src/runtime/panic.go:770 +0x132
github.com/hashicorp/terraform-provider-google/google/functions_test.TestAccProviderFunction_region_from_zone(0xc000a9c000)
	/home/runner/work/magic-modules/magic-modules/google/functions/region_from_zone_test.go:19 +0x5e5
testing.tRunner(0xc000a9c000, 0x42f6f70)
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:1689 +0xfb
created by testing.(*T).Run in goroutine 1
	/opt/hostedtoolcache/go/1.22.0/x64/src/testing/testing.go:[17](https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/8191213673/job/22399923645#step:8:18)42 +0x390

The docs check thing is guaranteed to fail at the moment, and is being addressed e.g. here hashicorp/terraform-provider-google#17509

@SarahFrench Looking at this, the test fails because the environment variable GOOGLE_ZONE is not set, I added a check that insures that the runtime error doesn't happen but we would still run into a test failing due to nothing being set:

    vcr_utils.go:152: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: Error in function call
        
          on terraform_plugin_test.tf line 23, in output "zone":
          23:   value = provider::google::region_from_zone(google_compute_disk.default.zone)
            ├────────────────
            │ while calling provider::google::region_from_zone(zone)
            │ google_compute_disk.default.zone is ""
        
        Call to function "provider::google::region_from_zone" failed: No matches
        present in the input string: The input string cannot be empty..

Out of curiosity I went ahead and checked location_from_id_test.go on how it handles an empty GOOGLE_REGION and it also returns an Error:

=== RUN   TestAccProviderFunction_location_from_id
=== PAUSE TestAccProviderFunction_location_from_id
=== CONT  TestAccProviderFunction_location_from_id
    vcr_utils.go:152: Step 1/1 error: Error running apply: exit status 1
        
        Error: Error creating Service: Post "https://-run.googleapis.com/apis/serving.knative.dev/v1/namespaces/hc-terraform-testing/services?alt=json": tls: failed to verify certificate: x509: certificate is valid for *.googleapis.com, googleapis.com, cloudendpointsapis.com, *.cloudendpointsapis.com, *.p.googleapis.com, *.clients6.google.com, *.clients6.google.ac, *.clients6.google.ad, *.clients6.google.ae, *.clients6.google.af, *.clients6.google.ag, *.clients6.google.ai, *.clients6.google.al, *.clients6.google.am, *.clients6.google.as, *.clients6.google.at, *.clients6.google.az, *.clients6.google.ba, *.clients6.google.be, *.clients6.google.bf, *.clients6.google.bg, *.clients6.google.bi, *.clients6.google.bj, *.clients6.google.bs, *.clients6.google.bt, *.clients6.google.by, *.clients6.google.bzh, *.clients6.google.ca, *.clients6.google.cat, *.clients6.google.cc, *.clients6.google.cd, *.clients6.google.cf, *.clients6.google.cg, *.clients6.google.ch, *.clients6.google.ci, *.clients6.google.cl, *.clients6.google.cm, *.clients6.google.cn, *.clients6.google.co.ao, *.clients6.google.co.bw, *.clients6.google.co.ck, *.clients6.google.co.cr, *.clients6.google.co.hu, *.clients6.google.co.id, *.clients6.google.co.il, *.clients6.google.co.im, *.clients6.google.co.in, *.clients6.google.co.je, *.clients6.google.co.jp, *.clients6.google.co.ke, *.clients6.google.co.kr, *.clients6.google.co.ls, *.clients6.google.co.ma, *.clients6.google.co.mz, *.clients6.google.co.nz, *.clients6.google.co.th, *.clients6.google.co.tz, *.clients6.google.co.ug, *.clients6.google.co.uk, *.clients6.google.co.uz, *.clients6.google.co.ve, *.clients6.google.co.vi, *.clients6.google.co.za, *.clients6.google.co.zm, *.clients6.google.co.zw, *.clients6.google.com.af, *.clients6.google.com.ag, *.clients6.google.com.ai, *.clients6.google.com.ar, *.clients6.google.com.au, *.clients6.google.com.bd, *.clients6.google.com.bh, *.clients6.google.com.bn, *.clients6.google.com.bo, *.clients6.google.com.br, *.clients6.google.com.by, *.clients6.google.com.bz, *.clients6.google.com.co, *.clients6.google.com.cu, *.clients6.google.com.cy, *.clients6.google.com.do, *.clients6.google.com.ec, *.clients6.google.com.eg, *.clients6.google.com.et, *.clients6.google.com.fj, *.clients6.google.com.ge, *.clients6.google.com.gh, *.clients6.google.com.gi, *.clients6.google.com.gr, *.clients6.google.com.gt, *.clients6.google.com.hk, *.clients6.google.com.iq, *.clients6.google.com.jm, *.clients6.google.com.jo, *.clients6.google.com.kh, *.clients6.google.com.kw, *.clients6.google.com.lb, *.clients6.google.com.ly, *.clients6.google.com.mm, *.clients6.google.com.mt, *.clients6.google.com.mx, *.clients6.google.com.my, *.clients6.google.com.na, *.clients6.google.com.nf, *.clients6.google.com.ng, *.clients6.google.com.ni, *.clients6.google.com.np, *.clients6.google.com.nr, *.clients6.google.com.om, *.clients6.google.com.pa, *.clients6.google.com.pe, *.clients6.google.com.pg, *.clients6.google.com.ph, *.clients6.google.com.pk, *.clients6.google.com.pl, *.clients6.google.com.pr, *.clients6.google.com.py, *.clients6.google.com.qa, *.clients6.google.com.ru, *.clients6.google.com.sa, *.clients6.google.com.sb, *.clients6.google.com.sg, *.clients6.google.com.sl, *.clients6.google.com.sv, *.clients6.google.com.tj, *.clients6.google.com.tn, *.clients6.google.com.tr, *.clients6.google.com.tw, *.clients6.google.com.ua, *.clients6.google.com.uy, *.clients6.google.com.vc, *.clients6.google.com.ve, *.clients6.google.com.vn, *.clients6.google.cv, *.clients6.google.cz, *.clients6.google.de, *.clients6.google.dj, *.clients6.google.dk, *.clients6.google.dm, *.clients6.google.dz, *.clients6.google.ee, *.clients6.google.es, *.clients6.google.eus, *.clients6.google.fi, *.clients6.google.fm, *.clients6.google.fr, *.clients6.google.frl, *.clients6.google.ga, *.clients6.google.gal, *.clients6.google.ge, *.clients6.google.gg, *.clients6.google.gl, *.clients6.google.gm, *.clients6.google.gp, *.clients6.google.gr, *.clients6.google.gy, *.clients6.google.hk, *.clients6.google.hn, *.clients6.google.hr, *.clients6.google.ht, *.clients6.google.hu, *.clients6.google.ie, *.clients6.google.im, *.clients6.google.in, *.clients6.google.info, *.clients6.google.iq, *.clients6.google.ir, *.clients6.google.is, *.clients6.google.it, *.clients6.google.it.ao, *.clients6.google.je, *.clients6.google.jo, *.clients6.google.jobs, *.clients6.google.jp, *.clients6.google.kg, *.clients6.google.ki, *.clients6.google.kz, *.clients6.google.la, *.clients6.google.li, *.clients6.google.lk, *.clients6.google.lt, *.clients6.google.lu, *.clients6.google.lv, *.clients6.google.md, *.clients6.google.me, *.clients6.google.mg, *.clients6.google.mk, *.clients6.google.ml, *.clients6.google.mn, *.clients6.google.ms, *.clients6.google.mu, *.clients6.google.mv, *.clients6.google.mw, *.clients6.google.ne, *.clients6.google.ne.jp, *.clients6.google.net, *.clients6.google.ng, *.clients6.google.nl, *.clients6.google.no, *.clients6.google.nr, *.clients6.google.nu, *.clients6.google.off.ai, *.clients6.google.pk, *.clients6.google.pl, *.clients6.google.pn, *.clients6.google.ps, *.clients6.google.pt, *.clients6.google.ro, *.clients6.google.rs, *.clients6.google.ru, *.clients6.google.rw, *.clients6.google.sc, *.clients6.google.se, *.clients6.google.sh, *.clients6.google.si, *.clients6.google.sk, *.clients6.google.sm, *.clients6.google.sn, *.clients6.google.so, *.clients6.google.sr, *.clients6.google.st, *.clients6.google.td, *.clients6.google.tel, *.clients6.google.tg, *.clients6.google.tk, *.clients6.google.tl, *.clients6.google.tm, *.clients6.google.tn, *.clients6.google.to, *.clients6.google.tt, *.clients6.google.us, *.clients6.google.uz, *.clients6.google.vg, *.clients6.google.vu, *.clients6.google.ws, not -run.googleapis.com
        
          with google_cloud_run_service.default,
          on terraform_plugin_test.tf line 11, in resource "google_cloud_run_service" "default":
          11: resource "google_cloud_run_service" "default" {
        
--- FAIL: TestAccProviderFunction_location_from_id (4.68s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-google/google/functions 5.667s
FAIL
make: *** [testacc] Error 1

once i included the environmental variable for both tests they both pass.

The latest commit fixes the runtime error. But when it comes to running tests for functions aren't we expecting environmental variables to be appropriately set?

This does make it easier for someone to fix the issue the next time someone attempts to run the test without setting GOOGLE_ZONE first

BBBmau avatar Mar 08 '24 20:03 BBBmau

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 286 insertions(+)) Terraform Beta: Diff ( 5 files changed, 286 insertions(+))

modular-magician avatar Mar 08 '24 20:03 modular-magician

Tests analytics

Total tests: 3500 Passed tests: 3108 Skipped tests: 355 Affected tests: 37

Click here to see the affected service packages
all service packages are affected

Action taken

Found 37 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_buildworkerpool|TestAccCloudFunctionsFunction_update|TestAccComposerEnvironmentComposer3_basic|TestAccComposerEnvironmentComposer3_update|TestAccComposerEnvironmentComposer3_updateFromEmpty|TestAccComposerEnvironmentComposer3_updateToEmpty|TestAccComputeBackendService_regionNegBackend|TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetFqdnPortExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetIpPortExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetFqdnPortExample|TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetIpPortExample|TestAccComputeRegionTargetTcpProxy_update|TestAccDataSourceGoogleServiceAccountJwt|TestAccDataSourceRegionNetworkEndpointGroup_basic|TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigUpdate|TestAccGKEHub2ScopeIamBindingGenerated|TestAccGKEHub2ScopeIamMemberGenerated|TestAccGKEHub2ScopeIamPolicyGenerated|TestAccGKEHub2Scope_gkehubScopeBasicExample|TestAccGKEHub2Scope_gkehubScopeBasicExample_update|TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_waitForStatus|TestAccNotebooksRuntime_update|TestAccProviderFunction_location_from_id|TestAccProviderFunction_project_from_id|TestAccRegionInstanceGroupManager_update|TestAccSecurityposturePosture_securityposturePostureBasicExample|TestAccStorageBucket_lifecycleRulesNoAge

Get to know how VCR tests work

modular-magician avatar Mar 08 '24 21:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccCertificateManagerDnsAuthorization_certificateManagerDnsAuthorizationBasicExample[Debug log] TestAccCloudFunctionsFunction_basic[Debug log] TestAccCloudFunctionsFunction_buildworkerpool[Debug log] TestAccCloudFunctionsFunction_update[Debug log] TestAccComposerEnvironmentComposer3_basic[Debug log] TestAccComposerEnvironmentComposer3_update[Debug log] TestAccComposerEnvironmentComposer3_updateFromEmpty[Debug log] TestAccComposerEnvironmentComposer3_updateToEmpty[Debug log] TestAccComputeBackendService_regionNegBackend[Debug log] TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetFqdnPortExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetIpPortExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log] TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetFqdnPortExample[Debug log] TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetIpPortExample[Debug log] TestAccComputeRegionTargetTcpProxy_update[Debug log] TestAccDataSourceGoogleServiceAccountJwt[Debug log] TestAccDataSourceRegionNetworkEndpointGroup_basic[Debug log] TestAccFirebaseAppCheckAppAttestConfig_firebaseAppCheckAppAttestConfigUpdate[Debug log] TestAccGKEHub2ScopeIamBindingGenerated[Debug log] TestAccGKEHub2ScopeIamMemberGenerated[Debug log] TestAccGKEHub2ScopeIamPolicyGenerated[Debug log] TestAccGKEHub2Scope_gkehubScopeBasicExample[Debug log] TestAccGKEHub2Scope_gkehubScopeBasicExample_update[Debug log] TestAccGkeonpremVmwareCluster_gkeonpremVmwareClusterF5lbExample[Debug log] TestAccInstanceGroupManager_update[Debug log] TestAccInstanceGroupManager_waitForStatus[Debug log] TestAccNotebooksRuntime_update[Debug log] TestAccRegionInstanceGroupManager_update[Debug log] TestAccSecurityposturePosture_securityposturePostureBasicExample[Debug log] TestAccStorageBucket_lifecycleRulesNoAge[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccProviderFunction_location_from_id[Error message] [Debug log] TestAccProviderFunction_project_from_id[Error message] [Debug log]

$\textcolor{red}{\textsf{Several tests got terminated during RECORDING mode.}}$ $\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 08 '24 22:03 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 283 insertions(+)) Terraform Beta: Diff ( 5 files changed, 283 insertions(+))

modular-magician avatar Mar 11 '24 16:03 modular-magician

Tests analytics

Total tests: 3500 Passed tests: 3141 Skipped tests: 355 Affected tests: 4

Click here to see the affected service packages
all service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccProviderFunction_location_from_id|TestAccProviderFunction_project_from_id

Get to know how VCR tests work

modular-magician avatar Mar 11 '24 17:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample[Debug log] TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccProviderFunction_location_from_id[Error message] [Debug log] TestAccProviderFunction_project_from_id[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 11 '24 17:03 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 281 insertions(+)) Terraform Beta: Diff ( 5 files changed, 281 insertions(+))

modular-magician avatar Mar 11 '24 19:03 modular-magician