magic-modules
magic-modules copied to clipboard
Graduate support of GKE Queued Provisioning to GA
Graduate support of GKE Queued Provisioning to GA
Release Note Template for Downstream PRs (will be copied)
container: promoted `google_container_node_pool.queued_provisioning` to GA (ga)
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Nvm, we still need to wait for the necessary Go client to be released.
Actually, we can progress with it even now, it should be good to go with the current version of google.golang.org/api
package (v0.167.0
).
@roaks3 PTAL :)
/lgtm
/gcbrun
/gcbrun
@roaks3 what seems to be the issue for the build?
/gcbrun
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 108 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
We have been making a number of changes to PR checks, and I think the remaining "Build" error is a result of getting into a weird state. Apologies for the inconvenience for what should be a straight-forward change. Could you try rebasing to resolve? If that doesn't work, it may be easiest to re-open a PR with the same changes.
FWIW, the code changes here LGTM, and we would just like to see the checks all pass, as well as confirmation that the GA tests pass locally for you (GA tests do not get run in our PR checks).
/gcbrun
confirmation that the GA tests pass locally for you (GA tests do not get run in our PR checks)
They pass when I execute them on my machine :).
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 3 files changed, 108 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))