magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Graduate support of GKE Queued Provisioning to GA

Open tosi3k opened this issue 1 year ago • 5 comments

Graduate support of GKE Queued Provisioning to GA

Release Note Template for Downstream PRs (will be copied)

container: promoted `google_container_node_pool.queued_provisioning` to GA (ga)

tosi3k avatar Feb 26 '24 16:02 tosi3k

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 26 '24 16:02 github-actions[bot]

Nvm, we still need to wait for the necessary Go client to be released.

tosi3k avatar Feb 26 '24 17:02 tosi3k

Actually, we can progress with it even now, it should be good to go with the current version of google.golang.org/api package (v0.167.0).

@roaks3 PTAL :)

tosi3k avatar Feb 29 '24 14:02 tosi3k

/lgtm

kisieland avatar Feb 29 '24 14:02 kisieland

/gcbrun

roaks3 avatar Feb 29 '24 22:02 roaks3

/gcbrun

roaks3 avatar Mar 05 '24 22:03 roaks3

@roaks3 what seems to be the issue for the build?

kisieland avatar Mar 06 '24 14:03 kisieland

/gcbrun

roaks3 avatar Mar 06 '24 22:03 roaks3

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 108 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician avatar Mar 06 '24 22:03 modular-magician

We have been making a number of changes to PR checks, and I think the remaining "Build" error is a result of getting into a weird state. Apologies for the inconvenience for what should be a straight-forward change. Could you try rebasing to resolve? If that doesn't work, it may be easiest to re-open a PR with the same changes.

FWIW, the code changes here LGTM, and we would just like to see the checks all pass, as well as confirmation that the GA tests pass locally for you (GA tests do not get run in our PR checks).

roaks3 avatar Mar 07 '24 19:03 roaks3

/gcbrun

roaks3 avatar Mar 12 '24 13:03 roaks3

confirmation that the GA tests pass locally for you (GA tests do not get run in our PR checks)

They pass when I execute them on my machine :).

tosi3k avatar Mar 12 '24 13:03 tosi3k

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 108 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

modular-magician avatar Mar 12 '24 14:03 modular-magician