magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

feat: Add CMEK support for Firestore database in Beta provider

Open jinyangtang opened this issue 1 year ago • 17 comments

Adds the new field cmek_config to google_firestore_database to support creating a Firestore CMEK database.

  • The change is added to Beta version only because it's only a Preview feature

Release Note Template for Downstream PRs (will be copied)

firestore: added `cmek_config` field to `google_firestore_database` resource

jinyangtang avatar Feb 24 '24 00:02 jinyangtang

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 24 '24 07:02 github-actions[bot]

/gcbrun

shuyama1 avatar Feb 25 '24 20:02 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 141 insertions(+)) Terraform Beta: Diff ( 3 files changed, 415 insertions(+)) TF Conversion: Diff ( 1 file changed, 40 insertions(+))

modular-magician avatar Feb 25 '24 21:02 modular-magician

Tests analytics

Total tests: 19 Passed tests: 17 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • firestore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample

Get to know how VCR tests work

modular-magician avatar Feb 25 '24 21:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccFirestoreDatabase_firestoreCmekDatabaseExample[Error message] [Debug log] TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 25 '24 22:02 modular-magician

Hi @shuyama1 I've allowlisted the testing project to create CMEK db (which maybe the reason for the above failed tests). Could you please help to trigger /gcbrun again? Thanks!

jinyangtang avatar Feb 28 '24 18:02 jinyangtang

Hi @rwhogg Could you please help to review this PR as a Firestore team member. Thanks!

jinyangtang avatar Feb 28 '24 19:02 jinyangtang

/gcbrun

shuyama1 avatar Feb 29 '24 15:02 shuyama1

/gcbrun

Thank you @shuyama1, I pushed another commit to resolve a comment, seems that it requires another /gcbrun. Do you mind running that again and help to review this PR when you get a change? (My tests all passed after allowlisting project to create cmek db). Thanks!

jinyangtang avatar Feb 29 '24 17:02 jinyangtang

/gcbrun

shuyama1 avatar Feb 29 '24 17:02 shuyama1

@jinyangtang Would you mind rebasing your PR? We have some recent CI changes and a rebase is needed to pick those up to trigger tests. Thanks!

shuyama1 avatar Feb 29 '24 17:02 shuyama1

/gcbrun

shuyama1 avatar Feb 29 '24 18:02 shuyama1

@shuyama1 I've done a rebase to the original repo, but seems that this PR is showing all commits that don't belong to me as well. Do you have any suggestion how I can resolve this? (And not sure if this is why the tests are not being run?

jinyangtang avatar Feb 29 '24 19:02 jinyangtang

/gcbrun

shuyama1 avatar Feb 29 '24 21:02 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 141 insertions(+)) Terraform Beta: Diff ( 3 files changed, 415 insertions(+)) TF Conversion: Diff ( 1 file changed, 40 insertions(+))

modular-magician avatar Feb 29 '24 21:02 modular-magician

Tests analytics

Total tests: 19 Passed tests: 17 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • firestore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample

Get to know how VCR tests work

modular-magician avatar Feb 29 '24 21:02 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccFirestoreDatabase_firestoreCmekDatabaseExample[Error message] [Debug log] TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Feb 29 '24 22:02 modular-magician

Hi @shuyama1 Thank you for your patience. Our rollout has just finished last night, would you mind triggering test to run again?

jinyangtang avatar Mar 05 '24 16:03 jinyangtang

/gcbrun

shuyama1 avatar Mar 05 '24 17:03 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 141 insertions(+)) Terraform Beta: Diff ( 3 files changed, 415 insertions(+)) TF Conversion: Diff ( 1 file changed, 40 insertions(+))

modular-magician avatar Mar 05 '24 17:03 modular-magician

Tests analytics

Total tests: 19 Passed tests: 17 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • firestore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample

Get to know how VCR tests work

modular-magician avatar Mar 05 '24 17:03 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccFirestoreDatabase_firestoreCmekDatabaseExample[Error message] [Debug log] TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Mar 05 '24 17:03 modular-magician

/gcbrun

shuyama1 avatar Mar 05 '24 18:03 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 141 insertions(+)) Terraform Beta: Diff ( 3 files changed, 415 insertions(+)) TF Conversion: Diff ( 1 file changed, 40 insertions(+))

modular-magician avatar Mar 05 '24 18:03 modular-magician

Tests analytics

Total tests: 19 Passed tests: 17 Skipped tests: 0 Affected tests: 2

Click here to see the affected service packages
  • firestore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_firestoreCmekDatabaseExample|TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample

Get to know how VCR tests work

modular-magician avatar Mar 05 '24 18:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccFirestoreDatabase_firestoreCmekDatabaseExample[Debug log] TestAccFirestoreDatabase_firestoreCmekDatabaseInDatastoreModeExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Mar 05 '24 18:03 modular-magician

Hi @shuyama1 I've rebased with master branch (successfully this time!), do you mind helping to trigger another gcbrun and review the change when you get a chance? Thanks!

jinyangtang avatar Mar 06 '24 06:03 jinyangtang

/gcbrun

shuyama1 avatar Mar 06 '24 20:03 shuyama1

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 141 insertions(+)) Terraform Beta: Diff ( 3 files changed, 415 insertions(+)) TF Conversion: Diff ( 1 file changed, 40 insertions(+))

modular-magician avatar Mar 06 '24 20:03 modular-magician

Tests analytics

Total tests: 19 Passed tests: 19 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages
  • firestore

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

modular-magician avatar Mar 06 '24 20:03 modular-magician