Add support for string --> object map for DCL resources

[slevenick]

Fixes: https://github.com/hashicorp/terraform-provider-google/issues/16777

Hard to test here because the corresponding changes to add a string --> object map haven't made their way to the DCL yet. I've built with a local version of the DCL and run tests successfully

This adds a key_name virtual field to the object that is used to index the object into the map.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 23 files changed, 956 insertions(+), 471 deletions(-)) Terraform Beta: Diff ( 23 files changed, 972 insertions(+), 479 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 540 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 540 insertions(+), 2 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gke_hub_feature_membership (17 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gke_hub_feature_membership" "primary" {
  policycontroller {
    policy_controller_hub_config {
      deployment_configs {
        deployment_type = # value needed
      }
    }
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 540 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 540 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3480 Passed tests: 3127 Skipped tests: 353 Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

[slevenick]

Tests pass in CI except for TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate which is unrelated

[slevenick]

Docs for these resources are weird (I think they're handwritten?), so you'll need to manually regenerate those!

Uhg, forgot about handwritten docs!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 629 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 629 insertions(+), 2 deletions(-))

[slevenick]

I'm unsure how there are failing tests, they are in firebase and those files are unchanged in downstreams

[modular-magician]

Tests analytics

Total tests: 3482 Passed tests: 3128 Skipped tests: 353 Affected tests: 1

Click here to see the affected service packages

all service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccProjectIamPolicy_invalidMembers[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test