magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Allow sending empty app_engine and serverless google_compute_region_network_endpoint_group

Open Cheriit opened this issue 1 year ago • 1 comments

Add sending empty values for SERVERLESS compute_region_network_endpoint_group NEG

fixes #15593

Release Note Template for Downstream PRs (will be copied)

compute: allowed sending empty values for `SERVERLESS` in `google_compute_region_network_endpoint_group` resource

Cheriit avatar Feb 22 '24 10:02 Cheriit

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions[bot] avatar Feb 22 '24 10:02 github-actions[bot]

/gcbrun

slevenick avatar Mar 06 '24 15:03 slevenick

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 57 insertions(+), 1 deletion(-)) Terraform Beta: Diff ( 3 files changed, 58 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) TF OiCS: Diff ( 4 files changed, 109 insertions(+))

modular-magician avatar Mar 06 '24 15:03 modular-magician

Tests analytics

Total tests: 890 Passed tests: 805 Skipped tests: 72 Affected tests: 13

Click here to see the affected service packages
  • compute

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeBackendService_regionNegBackend|TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineEmptyExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetFqdnPortExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetIpPortExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetFqdnPortExample|TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetIpPortExample|TestAccDataSourceRegionNetworkEndpointGroup_basic

Get to know how VCR tests work

modular-magician avatar Mar 06 '24 15:03 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeBackendService_regionNegBackend[Debug log] TestAccComputeRegionNetworkEndpointGroup_negWithServerlessDeployment[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineEmptyExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetFqdnPortExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupInternetIpPortExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscExample[Debug log] TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log] TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetFqdnPortExample[Debug log] TestAccComputeRegionNetworkEndpoint_regionNetworkEndpointInternetIpPortExample[Debug log] TestAccDataSourceRegionNetworkEndpointGroup_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

modular-magician avatar Mar 06 '24 15:03 modular-magician