magic-modules
magic-modules copied to clipboard
doc: Fix the description for attribute skip_initial_version_creation of the resource google_kms_crypto_key
It is actually possible to create a new CryptoKeyVersion using google_kms_crypto_key_version
resource, and not only google_kms_key_ring_import_job
. I suggest to update the documentation, so it does not confuse users.
That change was also requested by @melinath earlier on another PR's review: https://github.com/GoogleCloudPlatform/magic-modules/pull/6553#pullrequestreview-1111083661
Release Note Template for Downstream PRs (will be copied)
Fixed the description for attribute `skip_initial_version_creation` of the resource `google_kms_crypto_key`
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Sorry for the delay, lost this email!
/gcbrun
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders
to disable these notifications.
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 4 weeks. Please take a look! Use the label disable-review-reminders
to disable these notifications.
drive-by /gcbrun
@legal90 sorry for the delay on this review. Is there any chance you could rebase this PR against the main branch?
(or merge the main branch into this PR.) It's out of sync enough that the CI pipeline can't handle it at the moment.
FYI @rileykarson as reviewer.
@melinath Sure! Rebased now.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google
provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
google-beta
provider: Diff ( 2 files changed, 4 insertions(+), 2 deletions(-))
Tests analytics
Total tests: 35
Passed tests: 29
Skipped tests: 4
Affected tests: 2
Click here to see the affected service packages
- kms
Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update|TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions
$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccKMSEkmConnection_kmsEkmConnectionBasicExample_update
[Debug log]
TestAccKmsCryptoKeyVersion_externalProtectionLevelOptions
[Debug log]
$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test