switch to apache kafka
Description
Rerunning these commands failed due to untagging on Docker Hub (https://hub.docker.com/r/bitnami/kafka) for bitnami images. They have been moved to bitnamilegacy repo and no new tagging has been completed yet. Will just use Apache instead.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
- [x] I have followed Sample Format Guide
- [ ]
pom.xmlparent set to latestshared-configuration - [x] Appropriate changes to README are included in PR
- [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
- [ ] Tests pass:
mvn clean verifyrequired - [ ] Lint passes:
mvn -P lint checkstyle:checkrequired - [ ] Static Analysis:
mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only - [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
- [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
- [x] Please merge this PR for me once it is approved
@derrickaw any updates?
@derrickaw any updates?
Hi @iennae,
Documentation Context: Could you please add a brief note to the README explaining why we are moving from bitnami/kafka to apache/kafka? This helps future contributors (including sample reviewers) and users understand the dependency choice.
Will add.
Default Configuration: The Bitnami image often included built-in security defaults and environment variables. Have you confirmed that the basic apache/kafka image provides a drop-in functional equivalent for this simple setup, or if any additional variables are needed to maintain security/stability? We might want to add a note at the top around this sample showcasing how to do this for local development and not showing production-quality kafka configuration.
I have ran this in the same procedure as previous ones and it worked.
I think this means either refactoring the instructions or pin the image to a specific, recent 3.x.x version that is confirmed to be ZooKeeper-compatible and serves as a direct functional replacement. In general, it's better to pin to a specific version in samples to ensure that users can replicate a known good experience.
Let me investigate this some more.
Thanks!