Don't show deploy properties for undeployable projects

[elharo]

This is incorrect. The Dataflow properties are simply not shown on non-dataflow projects. We should do similarly.

[chanseokoh]

We introduced the above blank App Engine Deployment page above #1592, and in fact, there have been discussions if it's a good idea to show this all the time for every project (including plain Java projects).

In short, there was a technical reason that we decided to show it all the time: it seems not possible to dynamically add the App Engine Deployment page when a user manually installs our App Engine facet (i.e., via the Project Facets preference page) while the dialog is open. (However, if a user closes and re-opens the dialog, it'll be there.) @akerekes has a better context.

https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1592#discussion_r106085016 https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1592#discussion_r106275804

[akerekes]

I have nothing to add, @chanseok summarized it well.

On Fri, Apr 14, 2017, 18:59 Chanseok Oh [email protected] wrote:

We introduced the blank App Engine Deployment page above in #1592 https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1592, and in fact, there have been discussions if it's a good idea to show this all the time for every project (including plain Java projects).

In short, there was a technical reason that we decided to show it all the time: it seems not possible to dynamically add the App Engine Deployment page when a user manually installs our App Engine facet (i.e., via the Project Facets preference page) while the dialog is open. (However, if a user closes and re-opens the dialog, it'll be there.) @akerekes https://github.com/akerekes has a better context.

#1592 (comment) https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1592#discussion_r106085016 #1592 (comment) https://github.com/GoogleCloudPlatform/google-cloud-eclipse/pull/1592#discussion_r106275804

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/google-cloud-eclipse/issues/1811#issuecomment-294252312, or mute the thread https://github.com/notifications/unsubscribe-auth/ADOO_sW8VEJeVwYm14_YqzDIAJzBAlkfks5rv_pegaJpZM4M-EPx .