golang-samples
golang-samples copied to clipboard
getting-started/sessions: github.com/GoogleCloudPlatform/firestore-gorilla-sessions is no longer maintained
In which file did you encounter the issue?
https://github.com/GoogleCloudPlatform/golang-samples/blob/fa24a26ce9a0ad90efc8771472c7c1c57393cc9f/getting-started/sessions/go.mod#L7
Did you change the file? If so, how?
N/A
Describe the issue
The repository https://github.com/GoogleCloudPlatform/firestore-gorilla-sessions has been archived since 2022 and the last commit to the repository was 5 years ago.
It seems to be inappropriate to choose to use the firestore-gorilla-sessions library at this moment and the getting-stared/sessions example should be updated to the modern implementation, at least the example should not use firestore-gorilla-sessions.
The example is also displayed at the official document: https://cloud.google.com/go/getting-started/session-handling-with-firestore
Hi @gecko655 I noticed this comment about Gorilla Sessions being in flux until the Go v1.23 release. I also noticed under store implementations that they're still linking to firestore-gorilla-sessions.
Assuming holding off until gorilla/sessions stabilizes for the 1.23 release, are you suggesting using any particular store backend as a replacement, or are you suggesting using something altogether different from gorilla/sessions?
My understanding is that gorilla/sessions will continue developing, but GoogleCloudPlatform/firestore-gorilla-sessions seemed to have stopped being maintained.
There is still a link to GoogleCloudPlatform/firestore-gorilla-sessions in the README of the gorilla/sessions repository. However, this does not seem to imply that GoogleCloudPlatform/firestore-gorilla-sessions maintenance will continue in the future. It merely list the community maintained implementations that exist.
Since this repository itself belongs to the GoogleCloudPlatform organization, I believe the possible alternatives are one of the following:
- Make GoogleCloudPlatform/firestore-gorilla-sessions repository unarchive and continue to maintain it
- Using other gorilla/sessions backends for firestore (Like https://github.com/loveholidays/firestore-gorilla-sessions or other forked repository, or something else)
- Add a notice "GoogleCloudPlatform/firestore-gorilla-sessions is no longer maintained" to https://cloud.google.com/go/getting-started/session-handling-with-firestore
@gecko655 Thanks for your patience. We've updated the code to not rely on firestore-gorilla-sessions anymore.
👍 https://github.com/GoogleCloudPlatform/golang-samples/pull/5312