golang-samples icon indicating copy to clipboard operation
golang-samples copied to clipboard

feat(bigQueryv2): Add SecurityCommandCenter BigQueryExports samples

Open RajviM opened this issue 1 year ago • 5 comments

Description

Reference to https://b.corp.google.com/issues/339692211 This PR adds samples to use Create, Get, Update, Delete and List methods of SecurityCommandCenter v2 BigQueryExports.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [x] I have followed Contributing Guidelines from CONTRIBUTING.MD
  • [x] Tests pass: go test -v ./.. (see Testing)
  • [ ] Code formatted: gofmt (see Formatting)
  • [ ] Vetting pass: go vet (see Formatting)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ ] Please merge this PR for me once it is approved

RajviM avatar Jul 15 '24 16:07 RajviM

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jul 15 '24 16:07 snippet-bot[bot]

The kokoro checks seems to be failing on unrelated changes of this PR

RajviM avatar Jul 18 '24 16:07 RajviM

The kokoro checks seems to be failing on unrelated changes of this PR

Your PR is modifying a few go.mod and go.sum files outside the scope of your change, which is running these failing tests. If you limit this change to files under securitycenter, these problematic tests will not be run, and your tests will pass.

muncus avatar Jul 18 '24 21:07 muncus

The kokoro checks seems to be failing on unrelated changes of this PR

Your PR is modifying a few go.mod and go.sum files outside the scope of your change, which is running these failing tests. If you limit this change to files under securitycenter, these problematic tests will not be run, and your tests will pass.

These files were modified because of some previous checks failing. The suggestion command from that (after I ran) created these modification on the files.

Should I revert these files all together ? ( I'm new to development in golang + sample)

RajviM avatar Jul 18 '24 23:07 RajviM

These files were modified because of some previous checks failing. The suggestion command from that (after I ran) created these modification on the files.

Should I revert these files all together ? ( I'm new to development in golang + sample)

Yes, please revert the go.mod and go.sum changes outside of securitycenter. It is generally sufficient to run go mod tidy in the directory where you make changes, to update the nearest set of go.mod and go.sum files. (this is usually not a problem, but there are some pre-existing broken tests that need to be fixed...)

muncus avatar Jul 24 '24 16:07 muncus

Closed in preference of #4343

telpirion avatar Sep 04 '24 17:09 telpirion