golang-samples
golang-samples copied to clipboard
fixit: migrate to new region tag with prefix 'job_'
Description
- Internal: b/347825844
- Internal: b/347825952
- Internal: b/347825964
- Internal: b/347825934
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
- [x] I have followed Contributing Guidelines from CONTRIBUTING.MD
- [x] Tests pass:
go test -v ./..(see Testing) - [x] Code formatted:
gofmt(see Formatting) - [x] Vetting pass:
go vet(see Formatting) - [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
- [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
- [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
- [x] Please merge this PR for me once it is approved
Here is the summary of possible violations 😱
- jobs/v3/howto/basic_company_sample.go:27, tag
create_company(usage: page 1 page 2). - jobs/v3/howto/basic_company_sample.go:59, tag
get_company(usage: page 1). - jobs/v3/howto/custom_attribute_sample.go:28, tag
custom_attribute_job(usage: page 1 page 2). - jobs/v3/howto/custom_attribute_sample.go:61, tag
custom_attribute_filter_string_value(usage: page 1). - jobs/v3/howto/custom_attribute_sample.go:112, tag
custom_attribute_filter_long_value(usage: page 1). - jobs/v3/howto/custom_attribute_sample.go:163, tag
custom_attribute_filter_multi_attributes(usage: page 1). - jobs/v3/howto/location_based_search_sample.go:209, tag
keyword_location_search(usage: page 1).
The end of the violation section. All the stuff below is FYI purposes only.
Here is the summary of changes.
You are about to add 5 region tags.
- jobs/v3/howto/location_based_search_sample.go:26, tag
job_basic_location_search - jobs/v3/howto/location_based_search_sample.go:87, tag
job_city_location_search - jobs/v3/howto/location_based_search_sample.go:149, tag
job_broadening_location_search - jobs/v3/howto/location_based_search_sample.go:213, tag
job_keyword_location_search - jobs/v3/howto/location_based_search_sample.go:276, tag
job_multi_locations_search
You are about to delete 17 region tags.
- jobs/v3/howto/basic_company_sample.go:27, tag
create_company - jobs/v3/howto/basic_company_sample.go:59, tag
get_company - jobs/v3/howto/basic_company_sample.go:89, tag
update_company - jobs/v3/howto/basic_company_sample.go:120, tag
update_company_with_field_mask - jobs/v3/howto/basic_company_sample.go:153, tag
delete_company - jobs/v3/howto/basic_company_sample.go:180, tag
list_companies - jobs/v3/howto/basic_job_sample.go:87, tag
update_job - jobs/v3/howto/basic_job_sample.go:118, tag
update_job_with_field_mask - jobs/v3/howto/basic_job_sample.go:151, tag
delete_job - jobs/v3/howto/basic_job_sample.go:178, tag
list_jobs - jobs/v3/howto/custom_attribute_sample.go:28, tag
custom_attribute_job - jobs/v3/howto/custom_attribute_sample.go:61, tag
custom_attribute_filter_string_value - jobs/v3/howto/custom_attribute_sample.go:112, tag
custom_attribute_filter_long_value - jobs/v3/howto/custom_attribute_sample.go:163, tag
custom_attribute_filter_multi_attributes - jobs/v3/howto/location_based_search_sample.go:26, tag
basic_location_search - jobs/v3/howto/location_based_search_sample.go:209, tag
keyword_location_search - jobs/v3/howto/location_based_search_sample.go:272, tag
multi_locations_search
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
based on snippet checks, a couple of the snippets need to be a 2-phase where you add the region tag in this PR, submit the CL, wait for doc to get merged, then remove the existing region tag.
@iennae thank you for your review. given cl/648538021 is submitted, can I delete the corresponding old tags from this PR?