golang-samples icon indicating copy to clipboard operation
golang-samples copied to clipboard

fixit: migrate to new region tag with prefix 'job_'

Open ymotongpoo opened this issue 1 year ago • 2 comments

Description

  • Internal: b/347825844
  • Internal: b/347825952
  • Internal: b/347825964
  • Internal: b/347825934

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [x] I have followed Contributing Guidelines from CONTRIBUTING.MD
  • [x] Tests pass: go test -v ./.. (see Testing)
  • [x] Code formatted: gofmt (see Formatting)
  • [x] Vetting pass: go vet (see Formatting)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [x] Please merge this PR for me once it is approved

ymotongpoo avatar Jun 28 '24 07:06 ymotongpoo

Here is the summary of possible violations 😱

There are 7 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 5 region tags.
You are about to delete 17 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jun 28 '24 07:06 snippet-bot[bot]

based on snippet checks, a couple of the snippets need to be a 2-phase where you add the region tag in this PR, submit the CL, wait for doc to get merged, then remove the existing region tag.

iennae avatar Jun 28 '24 16:06 iennae

@iennae thank you for your review. given cl/648538021 is submitted, can I delete the corresponding old tags from this PR?

ymotongpoo avatar Jul 02 '24 01:07 ymotongpoo