golang-samples
golang-samples copied to clipboard
run/custom-metrics doesn't add SIGTERM/SIGINT handler for graceful shutdown
The Go program should add SIGTERM handler to shutdown the SDK. Right now it will just be ungracefully shutdown by Go's default SIGTERM handler, which means telemetry won't be flushed. See https://cloud.google.com/run/docs/samples/cloudrun-sigterm-handler
@aabmass I'm so sorry that you haven't had a response here. Can you share which sample you're asking to have updated? I'm not sure if you are asking for something specific or not (and whether it might have been addressed since)
Thank you.
No worries, this was filing a bug for a sample related to my team. It's this sample https://github.com/GoogleCloudPlatform/golang-samples/tree/main/run/custom-metrics