golang-samples icon indicating copy to clipboard operation
golang-samples copied to clipboard

Add gcloud tests to prevent regressions

Open shreejad opened this issue 3 years ago • 3 comments

gcloud 367.0.1 adds the Go modules functionality for App Engine Flex.

Golang's default behavior is to build an app the Go modules way if go.mod is present in any parent directory. In previous gcloud versions, even though go.mod was present in the root directory, gcloud ignored the file and build the app the GOPATH way. After gcloud 367.0.1, gcloud app deploy starts using the Go modules way to build the app. As GAE requires go.mod to be in the same directory as app.yaml, gcloud app deploy fails (go.mod is in the root directory while app.yaml is in a child sub-directory).

Suggestion: We should add gcloud tests (as part of PR presubmits maybe?) to prevent further regressions.

shreejad avatar Jan 22 '22 00:01 shreejad

I think we can update any samples that need to be, but I am not sure we should outright test gcloud here. I believe we always install the latest gcloud in our tests. If we need to re-build base containers to make sure there is a new enough version we can do that.

codyoss avatar Jan 24 '22 15:01 codyoss

gcp basic tutorial broken because of this. testing anyone?

splace avatar Mar 26 '22 14:03 splace

@splace Can you provide more details?

codyoss avatar Mar 28 '22 15:03 codyoss

Given the age of this issue and lack of sufficient details, I'm going to close. Please re-open with additional details if this issue arises again.

telpirion avatar Feb 24 '23 20:02 telpirion