gke-terraform-generator icon indicating copy to clipboard operation
gke-terraform-generator copied to clipboard

IntialNode Count MaxCount MinCount Validation

Open chrislovecnm opened this issue 5 years ago • 2 comments

The validation for initialNodeCount: 2 working weird.

This works

  nodePools:
    - metadata:
        name: my-node-pool
      spec:
        minCount: 2
        maxCount: 2
        initialNodeCount: 2

This does not work:

  nodePools:
    - metadata:
        name: my-node-pool
      spec:
        minCount: 2
        initialNodeCount: 2

This does not work:

  nodePools:
    - metadata:
        name: my-node-pool
      spec:
        initialNodeCount: 2

chrislovecnm avatar Sep 08 '19 18:09 chrislovecnm

We need to decide exactly how it should work. If initialNodeCount is set, but min and max are not set, what do we set them to?? How does this impact autoscaling??

@bgeesaman @robinpercy @wripley

chrislovecnm avatar Sep 08 '19 18:09 chrislovecnm

My thoughts:

If min and max are not set, no autoscaling is to be enabled OR, set min and max to same as initialnodecount and warn? If only min is set, validation error for not providing max.

bgeesaman avatar Sep 09 '19 15:09 bgeesaman