getting-started-python icon indicating copy to clipboard operation
getting-started-python copied to clipboard

Replace python-jose with google alternative

Open Jipje opened this issue 1 year ago • 4 comments

Closes #565

For more context to why python-jose should be replaced, please reference #565

This solution is a modified version of another repository of GoogleCloudPlatform: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/iap/validate_jwt.py. Although the code was modified as to minimize the amount of changes necessary in this repository.

The certs() method and CERTS global have been replaced by a certs_url parameter in the verify_token method. This did not change behaviour in the tests.

Jipje avatar May 02 '24 12:05 Jipje

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar May 02 '24 12:05 snippet-bot[bot]

@Jipje thanks for raising this and investigating a solution

/gcbrun

iennae avatar May 04 '24 02:05 iennae

Cheers @iennae, happy to help out. I am unable to view the details of the kokoro build so am unsure as to why it fails.

Is it anything to do with the adjusted # [START getting_started_auth_certs] comments?

Jipje avatar May 06 '24 07:05 Jipje

Bumping this @iennae

Jipje avatar Jun 26 '24 12:06 Jipje