gcping icon indicating copy to clipboard operation
gcping copied to clipboard

Add an options page with past runs and some controls

Open saranshdhingra opened this issue 3 years ago • 5 comments

I have tried to use similar themes and components as the website.

Have run eslint on the JS files and stylelint with the same config on the CSS file. Only non fixable errors are the incorrect selector-class-pattern in stylelint.

Apologies for the extra commits(I had taken the branch from a previously merged branch and then probably merged with the --no-ff flag)

Screens:

screen1

screen2

screen3

saranshdhingra avatar Jun 17 '22 17:06 saranshdhingra

PR staged at https://pr-116-09ba2d14d896f8060eef3c822329e06c0c72c7f5-5tkroniexa-uc.a.run.app

github-actions[bot] avatar Jun 17 '22 17:06 github-actions[bot]

@saranshdhingra would you mind rebasing this on top of main? It will be easier to review that way ;-)

enocom avatar Jun 28 '22 20:06 enocom

PR staged at https://pr-116-3be9a5d0e08a70ad2868d40543e2d26ec76f0c99-5tkroniexa-uc.a.run.app

github-actions[bot] avatar Jun 28 '22 20:06 github-actions[bot]

Since the extension is experimental, I think this looks good.

If we were investing more time in the extension, I'd like to see us re-use the overlapping code with the webapp, and figure out how to build both the webapp and the extension using that shared code. But that's a project for another day.

I would like that too. Perhaps if we spend some time on it soon, we can get that done :)

saranshdhingra avatar Jul 26 '23 09:07 saranshdhingra

I'm no longer part of this team. Perhaps @yuryu has some thoughts on this?

enocom avatar Jul 28 '23 16:07 enocom