functions-framework-nodejs icon indicating copy to clipboard operation
functions-framework-nodejs copied to clipboard

update readme.md to include ESM example

Open blazing234 opened this issue 1 year ago • 3 comments

update readme.md to include ESM example

blazing234 avatar Jan 14 '24 20:01 blazing234

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 14 '24 20:01 google-cla[bot]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

@kenneth-rosario Would this type of PR be able to be approved? I want to edit the cloud docs in general to include more ESM examples

blazing234 avatar Jan 16 '24 03:01 blazing234

We have a guide in docs that described how to use ESM: https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/main/docs/esm.md

I don't think we want to pull this into the main README as we want to keep in minimal.

matthewrobertson avatar Apr 26 '24 20:04 matthewrobertson