flink-on-k8s-operator icon indicating copy to clipboard operation
flink-on-k8s-operator copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Introduce CRD v1: fix CRD generation bugs and enable field validation

Open elanv opened this issue 4 years ago • 1 comments

This PR introduces CRD v1. CRD v1 is supported in Kubernetes version 1.16+.

  • Note There is a known issue(#382) for introducing CRD v1. For now, applied a workaround marking the CRD annotation api-approved.kubernetes.io as unapproved. Unapproved domain use is still a remaning issue.

  • Descrition

    • Fix CRD generation bugs (fix #311, fix #266, fix #330, fix #406, )
    • Reject unknown fields (fix #85)
    • Introduce CRD validation (via kubebuilder markers) Now can use kubebuilder validation markers that can partially replace the functions of default/validating webhooks and their test codes. https://book.kubebuilder.io/reference/markers/crd-validation.html

elanv avatar Mar 28 '21 01:03 elanv

Thanks for the fix!

@functicons @hongyegong Is there anything blocking merging this PR? Looks like the tests are blocked on someone approving the tests to run?

jlewi avatar Jun 22 '21 18:06 jlewi