GoogleCloudPlatform
Enforce the default http rule
Add the default http rule of a rpc endpoint to the additional_bindings field of any new http rules of that rpc endpoint. Otherwise, once a new http rule is set, the default http rule will no longer work, which is not expected.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dafudeng, nareddyt, TAOXUY
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [TAOXUY,dafudeng,nareddyt]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![google-oss-prow[bot] avatar](https://avatars.githubusercontent.com/in/143327?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dafudeng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ESPv2-gke-e2e-grpc-interop-managed | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-gke-e2e-grpc-interop-managed |
| ESPv2-cloud-run-e2e-cloud-run-grpc-echo | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-cloud-run-e2e-cloud-run-grpc-echo |
| ESPv2-gke-e2e-http-bookstore-managed | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-gke-e2e-http-bookstore-managed |
| ESPv2-gke-e2e-http-bookstore-managed-using-sa-cred | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-gke-e2e-http-bookstore-managed-using-sa-cred |
| ESPv2-gke-e2e-grpc-echo-managed | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-gke-e2e-grpc-echo-managed |
| ESPv2-presubmit-asan | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-presubmit-asan |
| ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore | 8f5edf2fd6f3e5da298492c8eff669eca64e9401 | link | true | /test ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.