emblem icon indicating copy to clipboard operation
emblem copied to clipboard

trigger using `unit-tests.cloudbuild.yaml` does not fail on step 2

Open rogerthatdev opened this issue 2 years ago • 0 comments

Thanks for stopping by to let us know something could be better!

PLEASE READ: This repository is dedicated to a sample application that uses multiple Google Cloud products. We will only be able to address issues related to this application, not to underlying issues in a client library or one of the products. Please visit the Support page to reach the most relevant engineers.

Problem

Unit tests that run via cloud build using unit-tests.cloudbuild.yaml do not fail at step 2 when a token is not retrieved successfully.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Initiate the api-unit-tests trigger by creating a PR that makes changes to content-api/**
  2. If fails, see that step 2 is marked as successful

Expected behavior

If a token is not retrieved, the build should fail at step 2.

Step 2 retrieves a token via bash and pipes it to python. It should either pipe only to more bash, or be passed along to another step that will execute the python, if required.

rogerthatdev avatar Jan 05 '23 00:01 rogerthatdev