dotnet-docs-samples icon indicating copy to clipboard operation
dotnet-docs-samples copied to clipboard

samples(storage batch operations): add samples and tests for storage batch operations

Open mahendra-google opened this issue 6 months ago • 13 comments

This PR contains samples and test cases to create, list, get, cancel and delete storage batch job operations.

The region tags used to create samples are as below:-

  • [ ] 1. storage_batch_create_job

  • [ ] 2. storage_batch_list_jobs

  • [ ] 3. storage_batch_get_job
  • [ ] 4. storage_batch_cancel_job
  • [ ] 5. storage_batch_delete_job

mahendra-google avatar Jun 23 '25 13:06 mahendra-google

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jun 23 '25 13:06 snippet-bot[bot]

@purva9413 After looking at errors from build log , I think Storage Batch Operations APIs are not enabled on both Kokoro servers i.e. Kokoro CI Linux 3 and Kokoro CI Windows 3.

mahendra-google avatar Jun 27 '25 01:06 mahendra-google

The API has been enabled but there are failing tests. Please take a look and also please address comments from the review. Thanks!

purva9413 avatar Jul 01 '25 21:07 purva9413

@purva9413 This test is not failing locally. Could you add kokoro label once I have done some code changes?

mahendra-google avatar Jul 16 '25 06:07 mahendra-google

@purva9413 Could you add kokoro label again?. This time I have added the null-conditional operator (?.) for all retrievedResponse properties and also added console logs to print those individual values to find exactly which value is null.

mahendra-google avatar Jul 23 '25 11:07 mahendra-google

@purva9413 This PR is ready for review.

mahendra-google avatar Jul 28 '25 06:07 mahendra-google

@purva9413 Could you review the retry logic implemented as a part of the recent code changes, with reference to the IAM pull request?

mahendra-google avatar Aug 20 '25 12:08 mahendra-google

Please fix failing tests.

purva9413 avatar Sep 08 '25 16:09 purva9413

@purva9413 Could you add once kokoro label? I want to check if the test is failing or not ?

mahendra-google avatar Sep 16 '25 05:09 mahendra-google

@purva9413 Gentle Reminder , This PR is ready for re-review

mahendra-google avatar Sep 24 '25 05:09 mahendra-google

Tests are still failing, please fix.

purva9413 avatar Sep 24 '25 17:09 purva9413

@purva9413 Could you add kokoro label again?.

mahendra-google avatar Sep 29 '25 13:09 mahendra-google

@purva9413 Gentle Reminder PR is ready for re-review

mahendra-google avatar Oct 30 '25 05:10 mahendra-google