dotnet-docs-samples icon indicating copy to clipboard operation
dotnet-docs-samples copied to clipboard

feat(modelarmor): Added snippets to sanitizer user prompt and model response

Open harshnasitcrest opened this issue 7 months ago • 9 comments

Added Model Armor samples for:

  • Sanitize User Prompt
  • Sanitize PDF file
  • Sanitize Model Response
  • Sanitize Model Response with User Prompt

harshnasitcrest avatar Jun 02 '25 11:06 harshnasitcrest

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Jun 02 '25 11:06 snippet-bot[bot]

You need to solve the conflicts on the PR to be able to merge.

amanda-tarafa avatar Jun 11 '25 05:06 amanda-tarafa

You need to solve the conflicts on the PR to be able to merge.

I have raised multiple PRs for Model Armor samples. Hence, I'll sequentially resolve merge conflicts and merge one-by-one.

harshnasitcrest avatar Jun 11 '25 05:06 harshnasitcrest

I've resolved merge conflicts on this PR. Could you please run kokoro labels to trigger CI actions?

harshnasitcrest avatar Jun 11 '25 07:06 harshnasitcrest

Tests are failing. These are API internal errors. How stable is the API? Even if we get it to green, are we certain we won't encounter service flakiness?

amanda-tarafa avatar Jun 11 '25 16:06 amanda-tarafa

Tests are failing. These are API internal errors. How stable is the API? Even if we get it to green, are we certain we won't encounter service flakiness?

I just started facing this error today. Let me check with Model Armor team whether this is also a known issue

harshnasitcrest avatar Jun 11 '25 16:06 harshnasitcrest

Were we able to get to a conclusion on the test failures here from the backend team?

purva9413 avatar Jun 23 '25 15:06 purva9413

Were we able to get to a conclusion on the test failures here from the backend team?

I discussed the issue with backend team yesterday. I will provide an update here accordingly.

harshnasitcrest avatar Jun 24 '25 07:06 harshnasitcrest

Were we able to get to a conclusion on the test failures here from the backend team?

I discussed the issue with backend team yesterday. I will provide an update here accordingly.

@purva9413 Model Armor team confirmed that the issues have been resolved. Latest tests runs are successful.

harshnasitcrest avatar Jun 30 '25 09:06 harshnasitcrest

@Anu4396 @purva9413 Thanks for the review! I've addressed all the feedback. Are we good to merge this PR?

harshnasitcrest avatar Jul 17 '25 05:07 harshnasitcrest