GoogleCloudPlatform
samples(storage): add samples and test cases for bucket soft delete policy
Add samples and test cases for bucket soft delete policy as follows:-
- [ ] storage_disable_soft_delete
- [ ] storage_get_soft_delete_policy
- [ ] storage_set_soft_delete_policy
Here is the summary of changes.
You are about to add 3 region tags.
- storage/api/Storage.Samples/BucketDisableSoftDeletePolicy.cs:15, tag
storage_disable_soft_delete - storage/api/Storage.Samples/BucketGetSoftDeletePolicy.cs:15, tag
storage_get_soft_delete_policy - storage/api/Storage.Samples/BucketSetSoftDeletePolicy.cs:15, tag
storage_set_soft_delete_policy
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
![snippet-bot[bot] avatar](https://avatars.githubusercontent.com/in/62122?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cy-yun BucketDisableSoftDeletePolicyTest.TestBucketDisableSoftDeletePolicy test is passing locally without any issues . Also on [Kokoro CI Windows 3] server it is passing in the first place and next time when it is running its failing. I am not sure what is the issue.
@cy-yun BucketDisableSoftDeletePolicyTest.TestBucketDisableSoftDeletePolicy test is passing locally without any issues . Also on [Kokoro CI Windows 3] server it is passing in the first place and next time when it is running its failing. I am not sure what is the issue.
Then there's a race condition or a flake that needs to be fixed anyway.
@cy-yun BucketDisableSoftDeletePolicyTest.TestBucketDisableSoftDeletePolicy test is passing locally without any issues . Also on [Kokoro CI Windows 3] server it is passing in the first place and next time when it is running its failing. I am not sure what is the issue.
Then there's a race condition or a flake that needs to be fixed anyway.
@amanda-tarafa if I do any code changes to resolve flake or race condition how can I test if error is fixed or not because I dont have previledge to add kokoro label to run the tests?
@cy-yun BucketDisableSoftDeletePolicyTest.TestBucketDisableSoftDeletePolicy test is passing locally without any issues . Also on [Kokoro CI Windows 3] server it is passing in the first place and next time when it is running its failing. I am not sure what is the issue.
Then there's a race condition or a flake that needs to be fixed anyway.
@amanda-tarafa if I do any code changes to resolve flake or race condition how can I test if error is fixed or not because I dont have previledge to add kokoro label to run the tests?
cy-yun , @amanda-tarafa Team (xWF: GCS Clients Development) confirmed that they are working on to add kokoro force run label on PR. Till the time I get permission to add kokoro force run label, I will not be able to resolve the error (race condition or test flakiness ).
@cy-yun BucketDisableSoftDeletePolicyTest.TestBucketDisableSoftDeletePolicy test is passing locally without any issues . Also on [Kokoro CI Windows 3] server it is passing in the first place and next time when it is running its failing. I am not sure what is the issue.
Then there's a race condition or a flake that needs to be fixed anyway.
@amanda-tarafa if I do any code changes to resolve flake or race condition how can I test if error is fixed or not because I dont have previledge to add kokoro label to run the tests?
@cy-yun , @amanda-tarafa Team (xWF: GCS Clients Development) confirmed that they are working on to add kokoro force run label on PR. Till that time error (race condition or test flakiness ) cannot be resolved.