GoogleCloudPlatform
samples (storage transfer) : add samples and test cases for storage transfer services
Adding samples and tests cases for following storage transfer services: storagetransfer_quickstart storagetransfer_transfer_to_nearline storagetransfer_get_latest_transfer_operation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Here is the summary of changes.
You are about to add 7 region tags.
- storagetransfer/api/StorageTransfer.Samples/CheckLatestTransferOperationSample.cs:14, tag
storagetransfer_get_latest_transfer_operation - storagetransfer/api/StorageTransfer.Samples/CreateEventDrivenGcsTransferSample.cs:16, tag
storagetransfer_create_event_driven_gcs_transfer - storagetransfer/api/StorageTransfer.Samples/DownloadToPosixSample.cs:14, tag
storagetransfer_download_to_posix - storagetransfer/api/StorageTransfer.Samples/TransferBetweenPosixSample.cs:14, tag
storagetransfer_transfer_posix_to_posix - storagetransfer/api/StorageTransfer.Samples/TransferFromPosixSample.cs:14, tag
storagetransfer_transfer_from_posix - storagetransfer/api/StorageTransfer.Samples/TransferToNearlineSample.cs:14, tag
storagetransfer_transfer_to_nearline - storagetransfer/api/StorageTransfer.Samples/TransferUsingManifestSample.cs:14, tag
storagetransfer_manifest_request
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
![snippet-bot[bot] avatar](https://avatars.githubusercontent.com/in/62122?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Please address this before any reviews.
@JesseLovelace or @danielduhh Can one of you or someone else from your team review these from a product perspective. I'll review from a language perspective after. Thanks.
@amanda-tarafa , is the shift from printing to the Console to printing to an test output helper acceptable here?
No, definetely not. @mahendra-google please follow contributing documentation both public and internal. It suggests to use the KMS set of samples as the canonical set of samples to base all other samples on. Thanks.
@amanda-tarafa , is the shift from printing to the Console to printing to an test output helper acceptable here?
No, definetely not. @mahendra-google please follow contributing documentation both public and internal. It suggests to use the KMS set of samples as the canonical set of samples to base all other samples on. Thanks.
@amanda-tarafa @JesseLovelace I will follow public and internal documentation and KMS set of samples . Also I am going to remove output helper from all files will replace it with Console.Writeline. Thank You.
Hi @JesseLovelace I have made code changes as per feedback. Can you please review it again?
@amanda-tarafa I think it got closed automatically by bot. I also received an email related to this closure.
I think you can just reopen the PR. The Reopen button is not active for me, but it may be active for you.
If you can't reopen it, create a new one.
We don't have a bot that closes PRs. And it says you closed it. I think you jus accidentally hit the wrong button.
I'll review both PRs, this one and the one for soft delete this week. I'm sorry for the delay, it usually doesn't take me this long to get to these PRs.
No worries for delay in reviewing but I think I did not close PR accidentally I also came to know when I received an email related to closure. The same scenario I observed in restore token soft delete PR as well that was also got closed automatically . I will check for a reopen option if not available I will create new PR. Thank You.
@amanda-tarafa I could not see option to reopen PR. I have created new PR for this (https://github.com/GoogleCloudPlatform/dotnet-docs-samples/pull/2857)