dotnet-docs-samples
dotnet-docs-samples copied to clipboard
GoogleCloudPlatform
feat: [DO NOT MERGE] support customer managed instance configurations
Adds samples for working with user managed instance configurations for Cloud Spanner.
Here is the summary of changes.
You are about to add 4 region tags.
-
spanner/api/Spanner.Samples/CreateInstanceConfigAsync.cs:15, tag
spanner_create_instance_config -
spanner/api/Spanner.Samples/DeleteInstanceConfigAsync.cs:15, tag
spanner_delete_instance_config -
spanner/api/Spanner.Samples/ListInstanceConfigOperationsAsync.cs:15, tag
spanner_list_instance_config_operations -
spanner/api/Spanner.Samples/UpdateInstanceConfigAsync.cs:15, tag
spanner_update_instance_config
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:
- [ ] Refresh this comment
![snippet-bot[bot] avatar](https://avatars.githubusercontent.com/in/62122?v=4 "Published by a pub.dev verified publisher"){kind=small}
I hadn't realized this was a draft, @AlexandrTrf can you confirm if this is ready for review or not? Thanks.
I hadn't realized this was a draft, @AlexandrTrf can you confirm if this is ready for review or not? Thanks.
@amanda-tarafa this code is ready. But it uses Google.Cloud.Scanner libraries that have not yet been released and now this code will not be able to be buit and the tests will not be passed.
@amanda-tarafa I have made the necessary changes. Could you do a review?
A couple of notes on the Async change.
Also let me know if/when the rest is done to re-review all. Thanks
Please perform a review of the code
I've made some requests that will apply to all samples and/or tests.
Done, please do a code review.
Two tiny nits, but otherwise LGTM.
I'll approve once the library with the needed changes is released and we can run the tests, but otherwise his looks good. Thanks!
Done
@AlexandrTrf this looks good, I'm just waiting for the released library to contain the feature so I can run the tests etc. Once the tests are green I'll appove and merge, thanks.
I've started the tests after updating the PR. If they are green we are ready to merge.