continuous-deployment-on-kubernetes icon indicating copy to clipboard operation
continuous-deployment-on-kubernetes copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Pushing a 'production' branch will deploy to the 'production' namespace

Open lvdh opened this issue 8 years ago • 2 comments

(... unless I am missing something.)

Granted, this is an edge case. However, it could be fixed with a straightforward and non-intrusive change. Being an example for an actual production setup, I believe this change would be a worthwhile addition.

Initial suggestion of a fix.

As per the contribution guidelines, I will submit a PR only if the proposed change is accepted.

lvdh avatar Jul 27 '17 12:07 lvdh

Hey @lvdh that sounds great!!! Lets make it happen.

(Apologies for the delay).

viglesiasce avatar Sep 19 '17 20:09 viglesiasce

Hi @viglesiasce, PR created; https://github.com/GoogleCloudPlatform/continuous-deployment-on-kubernetes/pull/116

Allow me to kindly refuse your apologies, and offer you mine. Apologies for the considerable delay!

lvdh avatar Feb 25 '18 16:02 lvdh