cloud-opensource-java icon indicating copy to clipboard operation
cloud-opensource-java copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Check google-oauth-client and google-api-client not being part of the Libraries BOM

Open suztomo opened this issue 3 years ago • 3 comments

CC: @claudio4j. Google HTTP Client is part of the Libraries BOM. How about the following two libraries?

  • google-oauth-client
  • google-api-client

(To dig dependencies)

suztomo avatar May 18 '22 17:05 suztomo

Adding these libraries would be exactly what I need. Thanks.

claudio4j avatar May 19 '22 16:05 claudio4j

The artifacts with google-cloud-XXX usually do not depend on google-oauth-client and google-api-client. Even when some of them depend on the two libraries, I don't expect users need to touch classes from google-oauth-client or google-api-client.

The above might be wrong for your situation. For my learning, would you share where you do you see the need of declaring the two libraries?

suztomo avatar May 19 '22 18:05 suztomo

https://github.com/apache/camel/blob/main/components/camel-google/camel-google-mail/src/main/java/org/apache/camel/component/google/mail/BatchGoogleMailClientFactory.java#L51

We use to process authentication, where we require the user to supply clientId, clientSecret, refreshToken, accessToken

claudio4j avatar May 19 '22 18:05 claudio4j

The BOM has moved to https://github.com/googleapis/java-cloud-bom repository.

suztomo avatar Feb 22 '24 15:02 suztomo