cloud-builders icon indicating copy to clipboard operation
cloud-builders copied to clipboard

[FR] Add `version` command to gke-deploy, reporting the git SHA used to build it

Open ffissore opened this issue 4 years ago • 3 comments

Detailed Feature Information

Which builder is relevant to this request? gcr.io/cloud-builders/gke-deploy

Is your feature request related to a problem? Please describe. #767 was merged with a fix to #766, but we are still experiencing it. Either the fix was insufficient or it hasn't been deployed to gcr.io yet. There's no way to know which SHA of this repo gke-deploy is based on, so I cannot know if it's just old or if the fix didn't fix.

Describe the solution you'd like Add command gke-deploy version: it should print the SHA used to build the binary, and any other information you think is relevant

Describe alternatives you've considered I thought about building it myself and compare the binaries, but I don't know if go builds are deterministic (same code = same binary checksums)

ffissore avatar May 13 '21 12:05 ffissore

Hi Federico, apologies for responding to this so late. I have returned from leave and am still catching up on things.

It looks like the latest image should have the changes you need. Please let me know if it doesn't.

We aren't prioritizing adding new features to gke-deploy. I'd be happy to take a look at any PRs, though.

joonlim avatar Jun 08 '21 00:06 joonlim

I confirm the image has been updated, as we haven't seen the problem occurring any more

ffissore avatar Jun 08 '21 08:06 ffissore

As for the version command, I'll try to set up a PR

ffissore avatar Jun 08 '21 08:06 ffissore

Closing issue as the original reported problem was fixed.

haroonc avatar Feb 27 '24 21:02 haroonc