buildpacks icon indicating copy to clipboard operation
buildpacks copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

Yarn2 workspace focus regression

Open tilgovi opened this issue 1 year ago • 5 comments

With f3ac43007d38b7dd2a94ce3c2f0d2cf498f91e9b, yarn workspaces focus is run regardless of the result of HasYarnWorkspacePlugin, which will fail when the workspaces plugin is absent. This is a regression from the behavior before that commit, wherein the buildpack would skip running yarn workspaces focus.

tilgovi avatar Aug 08 '22 20:08 tilgovi

Hi @tilgovi thanks for reporting this and the excellent debugging. We are working on a fix.

spew avatar Aug 14 '22 13:08 spew

This has been fixed but is only rolled out to cloud run deploy. It is not yet available for functions and appengine builds.

spew avatar Aug 16 '22 20:08 spew

@spew is there any place that I can monitor for when buildpack changes roll out to functions?

tilgovi avatar Aug 25 '22 22:08 tilgovi

We don't have a way for you to programatically monitor, however, you can try running a gcloud functions deploy and take a look at the associated build that is produced. The 'name' of each build step is a docker image. When the tag of the image changes then we have done a release.

If your builds are using image with tag nodejs16_20220821_16_16_0_RC00 then you have the latest changes.

spew avatar Aug 29 '22 14:08 spew

@tilgovi I don't have a test application for this issue (or else I would verify myself), has this issue been fixed for you?

spew avatar Aug 31 '22 15:08 spew

Looking good. Thank you.

tilgovi avatar Oct 17 '22 20:10 tilgovi